[tahoe-lafs-trac-stream] [Tahoe-LAFS] #1159: stop using .tac files: make it possible to change appname, Python package-directory name, perhaps other names

[Tahoe-LAFS]

#1159: stop using .tac files: make it possible to change appname, Python package-
directory name, perhaps other names
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  daira
  davidsarah             |     Status:  closed
         Type:  defect   |  Milestone:  1.11.0
     Priority:  major    |    Version:  1.8β
    Component:  code-    |   Keywords:  test-needed backward-compatibility
  nodeadmin              |  forward-compatibility appname tac needs-spawn
   Resolution:  fixed    |  packaging setuptools review-needed
Launchpad Bug:           |
-------------------------+-------------------------------------------------
Changes (by daira):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Fixed in [changeset:87a6894e6299148d639279fbd909110ba00d0080/trunk].

 Replying to [comment:50 warner]:
 > Note that this patch doesn't completely close #1159: it stops using the
 *contents* of the .tac files, but still relies upon their presence, in
 particular their filename: if "client" is a substring of the filename of
 the first .tac file found in the node's basedir, then we instantiate a
 `Client`, if "introducer" is in the string, we instantiate an
 `IntroducerNode`, etc.
 >
 > We'll want another patch, after 1.11, to move this indicator into
 tahoe.cfg (and look for a .tac filename as a backwards-compatibility
 tool).

 Filed as #2325. What we've done with this patch is sufficient to "make it
 possible to change appname (#2011), Python package-directory name (#1950),
 perhaps other names".

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1159#comment:53>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage