[tahoe-lafs-trac-stream] [Tahoe-LAFS] #1010: anonymous client mode

[Tahoe-LAFS]

#1010: anonymous client mode
-------------------------+-------------------------------------------------
     Reporter:  duck     |      Owner:  warner
         Type:           |     Status:  new
  enhancement            |  Milestone:  soon
     Priority:  minor    |    Version:  1.6.1
    Component:  code-    |   Keywords:  privacy anonymity docs anti-
  network                |  censorship forward-compatibility i2p-collab i2p
   Resolution:           |  tor
Launchpad Bug:           |
-------------------------+-------------------------------------------------

Comment (by str4d):

 Reviewed :)

 `src/allmydata/node.py`:
 * Line 72 can be removed (left over after creating `anonymize.py`).
 * `is_err` in `check_anonymity_config()` can be replaced with set unions
 (joining the expressions with `or`-s).
 * Line 236 (`tubport = ...`) can be moved inside the `self.anonymize`
 check.
 * Is a separate `_unreachable_tub()` necessary? AFAICT removing lines
 356-359 and changing line 360 to `if location != "UNREACHABLE" and not
 self.anonymize:` would have the same effect (apart from the log line,
 which could be checked inside `_setup_tub()` instead. This is probably a
 coding style decision, I will defer to Zooko et al. on this.

 `src/allmydata/util/anonymize.py`:
 * `is_anonymous()` still contains code to split a location hint into
 parts, which is what IMHO should be centralized (outside of
 `anonymize.py`). I haven't hunted for where else location hints are split
 up currently, but per the anonymity roadmap there will be more parts in
 Tahoe that will need to do so (e.g. per-config client endpoint string
 parameters).

 Overall IMHO this is looking very nice. It can't be directly merged to
 close this ticket because of the Tor-only content, and I'm not sure
 whether it can even be cherry-picked (I haven't checked which commits do
 what).

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1010#comment:49>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage