[tahoe-lafs-trac-stream] [Tahoe-LAFS] #1928: web redirects should use relative URLs

[Tahoe-LAFS]

#1928: web redirects should use relative URLs
-----------------------------------+----------------------------------
     Reporter:  leif               |      Owner:  davidsarah
         Type:  defect             |     Status:  assigned
     Priority:  normal             |  Milestone:  soon
    Component:  code-frontend-web  |    Version:  1.9.2
   Resolution:                     |   Keywords:  http redirect webapi
Launchpad Bug:                     |
-----------------------------------+----------------------------------

Comment (by daira):

 #2299 was a duplicate:
 > I'm forwarding :3456 to my local machine as :34561 via SSH, but whenever
 I click a link/button, like "View File or Directory" or "Recent and Active
 Operations", I get redirected to a page at :3456 and hit a 404. In the
 case of the "Recent and Active Operations" link, the anchor-tag just
 specifies "status" for the *href* and I don't think it's being preempted
 in JS (the next JS that runs seems to be something like "unloadEvent").
 Therefore, it might be getting redirected at the web-server or the
 backend.

 warner wrote on that ticket:
 >  Hrm, I thought we'd fixed all of the href targets and form/button
 targets to use relative URLs. Originally there were lots of absolute URLs
 (which caused exactly this problem: we had some !AllMyData servers that
 basically reverse-proxied requests into a localhost:3456 URL, and every
 once in a while the internal host+port would leak). I remember that some
 of the absolute URLs were not easy to fix (but I don't remember the
 reasons right now).
 >
 > Nothing should be getting updated with JS.. it should all be the
 responsiblity of the HTML-generating code in
 [source:src/allmydata/web/directory.py].

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1928#comment:4>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage