[tahoe-lafs-trac-stream] [Tahoe-LAFS] #1823: is this server telling me over foolscap that its foolscap connection to me just broke?

[Tahoe-LAFS]

#1823: is this server telling me over foolscap that its foolscap connection to me
just broke?
------------------------------+-----------------------
     Reporter:  zooko         |      Owner:
         Type:  defect        |     Status:  new
     Priority:  normal        |  Milestone:  undecided
    Component:  code-network  |    Version:  1.9.2
   Resolution:                |   Keywords:  foolscap
Launchpad Bug:                |
------------------------------+-----------------------

Old description:

> My local wifi is flapping up and down as I try to fix it, and I just got
> this failure from my local Tahoe-LAFS gateway, which is connected to
> exactly one storage server (a !LeastAuthority.com server).
>
> {{{yu3a}}} is my gateway, {{{66ra}}} is the storage server.
>
> {{{
> 06:20:34.655 [1422]: UNUSUAL an outbound callRemote (that we [yu3a] sent
> to someone else [66ra]) failed on the far end
>
>     06:20:34.655 [1423]: reqID=1899, rref=<RemoteReference at 0x33cf3d0
> [pb://66rayrcb444dtmcbkuu4typhxcijdg4l@75.101.197.126:12346,10.120.62.180:12346/mbgetcemfcxlejev25bwfyhzrbdiowiu]>,
> methname=RIStorageServer.tahoe.allmydata.com.get_buckets
>     06:20:34.655 [1424]: the REMOTE failure was: FAILURE:
>
>     [CopiedFailure instance: Traceback from remote host -- Traceback
> (most recent call last):
>     Failure: foolscap.tokens.RemoteException: <RemoteException around
> '[CopiedFailure instance: Traceback from remote host -- Traceback (most
> recent call last):
>     Failure: twisted.internet.error.ConnectionLost: Connection to the
> other side was lost in a non-clean fashion.
>     ]'>
>     ]
>
> 06:20:34.655 [1425]: WEIRD <Checker #947>(67dnhwu46gw4): failure from
> server on 'get_buckets' the REMOTE failure was: FAILURE:
>
> [CopiedFailure instance: Traceback from remote host -- Traceback (most
> recent call last):
> Failure: foolscap.tokens.RemoteException: <RemoteException around
> '[CopiedFailure instance: Traceback from remote host -- Traceback (most
> recent call last):
> Failure: twisted.internet.error.ConnectionLost: Connection to the other
> side was lost in a non-clean fashion.
> ]'>
> ]
>
> [INCIDENT-TRIGGER]
> }}}
>
> I get confused about how many levels of "wrapping of remote thing" I'm
> seeing but since there are only two nodes involved, or three if you count
> the introducer, then I guess this means that the storage server told my
> local gateway that it had lost a foolscap connection. Does that make
> sense? Pretty confusing.
>
> The server was marked as not-connected on the welcome page after this,
> but Foolscap ''did'' eventually reconnect.
>
> Is this a bug, or should we just close this ticket as not-a-bug?

New description:

 My local wifi is flapping up and down as I try to fix it, and I just got
 this failure from my local Tahoe-LAFS gateway, which is connected to
 exactly one storage server (a !LeastAuthority.com server).

 {{{yu3a}}} is my gateway, {{{66ra}}} is the storage server.

 {{{
 06:20:34.655 [1422]: UNUSUAL an outbound callRemote (that we [yu3a] sent
 to someone else [66ra]) failed on the far end

     06:20:34.655 [1423]: reqID=1899, rref=<RemoteReference at 0x33cf3d0
 [pb://66rayrcb444dtmcbkuu4typhxcijdg4l@75.101.197.126:12346,10.120.62.180:12346/mbgetcemfcxlejev25bwfyhzrbdiowiu]>,
 methname=RIStorageServer.tahoe.allmydata.com.get_buckets
     06:20:34.655 [1424]: the REMOTE failure was: FAILURE:

     [CopiedFailure instance: Traceback from remote host -- Traceback (most
 recent call last):
     Failure: foolscap.tokens.RemoteException: <RemoteException around
 '[CopiedFailure instance: Traceback from remote host -- Traceback (most
 recent call last):
     Failure: twisted.internet.error.ConnectionLost: Connection to the
 other side was lost in a non-clean fashion.
     ]'>
     ]

 06:20:34.655 [1425]: WEIRD <Checker #947>(67dnhwu46gw4): failure from
 server on 'get_buckets' the REMOTE failure was: FAILURE:

 [CopiedFailure instance: Traceback from remote host -- Traceback (most
 recent call last):
 Failure: foolscap.tokens.RemoteException: <RemoteException around
 '[CopiedFailure instance: Traceback from remote host -- Traceback (most
 recent call last):
 Failure: twisted.internet.error.ConnectionLost: Connection to the other
 side was lost in a non-clean fashion.
 ]'>
 ]

 [INCIDENT-TRIGGER]
 }}}

 I get confused about how many levels of "wrapping of remote thing" I'm
 seeing but since there are only two nodes involved, or three if you count
 the introducer, then I guess this means that the storage server told my
 local gateway that it had lost a foolscap connection. Does that make
 sense? Pretty confusing.

 The server was marked as not-connected on the welcome page after this, but
 Foolscap ''did'' eventually reconnect.

 Is this a bug, or should we just close this ticket as not-a-bug?

--

Comment (by zooko):

 Would `f.check(RemoteException) and f.failure.check(DeadReferenceError)`
 evaluate to true when the Foolscap reference to the peer broke, but as
 long as the Foolscap reference didn't break, then it would be guaranteed
 never to evaluate to true, ''even'' if the remote peer was sending us
 messages maliciously crafted to try to make it to evaluate to true? That's
 what I want.

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1823#comment:2>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage