[tahoe-lafs-trac-stream] [Tahoe-LAFS] #2242: exception from parsing requirements

[Tahoe-LAFS]

#2242: exception from parsing requirements
---------------------------+-----------------------------------------------
     Reporter:  zooko      |      Owner:
         Type:  defect     |     Status:  new
     Priority:  normal     |  Milestone:  soon
    Component:  packaging  |    Version:  1.10.0
   Resolution:             |   Keywords:  setuptools pkg_resources coverage
Launchpad Bug:             |
---------------------------+-----------------------------------------------

Old description:

> as reported by ambimorph on IRC:
>
> {{{
> amber at abhyasa:~/tahoe-lafs$ bin/tahoe @python-coverage run --branch
> --include='src/allmydata/*' @tahoe debug trial allmydata.test.test_cli
> Traceback (most recent call last):
>   File "/usr/bin/python-coverage", line 5, in <module>
>     from pkg_resources import load_entry_point
>   File "/home/amber/tahoe-lafs/support/lib/python2.7/site-
> packages/setuptools-0.6c16dev4.egg/pkg_resources.py", line 2638, in
> <module>
>     working_set.add(dist)
>   File "/home/amber/tahoe-lafs/support/lib/python2.7/site-
> packages/setuptools-0.6c16dev4.egg/pkg_resources.py", line 532, in add
>     for thisreq in parse_requirements(thisreqstr):
>   File "/home/amber/tahoe-lafs/support/lib/python2.7/site-
> packages/setuptools-0.6c16dev4.egg/pkg_resources.py", line 2451, in
> parse_requirements
>     raise ValueError("Missing distribution spec", line)
> ValueError: ('Missing distribution spec', '=', {'thisreqstr': '='})
> }}}
>
> Investigation showed the the {{{__requires___}}} variable held a string
> ({{{"coverage==3.4"}}} instead of an iterable containing strings,
> therefor [https://tahoe-lafs.org/trac/tahoe-
> lafs/browser/trunk/setuptools-0.6c16dev4.egg/pkg_resources.py?annotate=blame&rev=5ab27f58cc35bc2abc87822798460021b9785e36#L527
> this code] in our splinter of setuptools tried to parse each character of
> that string.

New description:

 as reported by ambimorph on IRC:

 {{{
 amber at abhyasa:~/tahoe-lafs$ bin/tahoe @python-coverage run --branch
 --include='src/allmydata/*' @tahoe debug trial allmydata.test.test_cli
 Traceback (most recent call last):
   File "/usr/bin/python-coverage", line 5, in <module>
     from pkg_resources import load_entry_point
   File "/home/amber/tahoe-lafs/support/lib/python2.7/site-
 packages/setuptools-0.6c16dev4.egg/pkg_resources.py", line 2638, in
 <module>
     working_set.add(dist)
   File "/home/amber/tahoe-lafs/support/lib/python2.7/site-
 packages/setuptools-0.6c16dev4.egg/pkg_resources.py", line 532, in add
     for thisreq in parse_requirements(thisreqstr):
   File "/home/amber/tahoe-lafs/support/lib/python2.7/site-
 packages/setuptools-0.6c16dev4.egg/pkg_resources.py", line 2451, in
 parse_requirements
     raise ValueError("Missing distribution spec", line)
 ValueError: ('Missing distribution spec', '=', {'thisreqstr': '='})
 }}}

 Investigation showed the the {{{__requires___}}} variable held a string
 ({{{"coverage==3.4"}}}) instead of an iterable containing strings,
 therefore [https://tahoe-lafs.org/trac/tahoe-
 lafs/browser/trunk/setuptools-0.6c16dev4.egg/pkg_resources.py?annotate=blame&rev=5ab27f58cc35bc2abc87822798460021b9785e36#L527
 this code] in our splinter of setuptools tried to parse each character of
 that string.

--

Comment (by warner):

 This came up in #2378, causing one of the buildslaves to fail the "test-
 from-egg" step.

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2242#comment:3>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage