[tahoe-lafs-trac-stream] [Tahoe-LAFS] #2047: refactor *Source classes in tahoe_cp.py to have a basename() method rather than passing around (name, source) pairs

[Tahoe-LAFS]

#2047: refactor *Source classes in tahoe_cp.py to have a basename() method rather
than passing around (name, source) pairs
-----------------------------------+------------------------------
     Reporter:  daira              |      Owner:  daira
         Type:  defect             |     Status:  assigned
     Priority:  normal             |  Milestone:  undecided
    Component:  code-frontend-cli  |    Version:  1.10.0
   Resolution:                     |   Keywords:  cleanup tahoe-cp
Launchpad Bug:                     |
-----------------------------------+------------------------------

Comment (by warner):

 The source object might be a pure filecap or dircap, and thus have no
 name. I think I wrote it this way (with tuples) as a reminder of that
 feature/property. I wouldn't object to moving this value into an property
 or method of the `TahoeFileSource` and `LocalFileSource` objects, but I'm
 not sure that `basename()` is the best name for it, if that's likely to
 imply that it always exists.

 I think this assumption is the root cause for the #2329 regression.

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2047#comment:3>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage