[tahoe-lafs-trac-stream] [Tahoe-LAFS] #2462: remove bare asserts for segment out-of-range errors in mutable retrieve (was: remove bare assert for segment out-of-range error in mutable retrieve)

[Tahoe-LAFS]

#2462: remove bare asserts for segment out-of-range errors in mutable retrieve
-------------------------+-------------------------------------------------
     Reporter:  daira    |      Owner:  daira
         Type:  defect   |     Status:  assigned
     Priority:  normal   |  Milestone:  1.11.0
    Component:  code-    |    Version:  1.10.1
  mutable                |   Keywords:  cleanup error mutable retrieve
   Resolution:           |  download
Launchpad Bug:           |
-------------------------+-------------------------------------------------
Changes (by daira):

 * status:  new => assigned


Old description:

> {{{
> Traceback (most recent call last):
>   File
> "/home/davidsarah/tahoe/git/trunk/src/allmydata/mutable/filenode.py",
> line 990, in <lambda>
>     self._serializer.addCallback(lambda ignore: cb(*args, **kwargs))
>   File
> "/home/davidsarah/tahoe/git/trunk/src/allmydata/mutable/filenode.py",
> line 980, in _read
>     d = r.download(consumer, offset, size)
>   File
> "/home/davidsarah/tahoe/git/trunk/src/allmydata/mutable/retrieve.py",
> line 244, in download
>     self._setup_encoding_parameters()
>   File
> "/home/davidsarah/tahoe/git/trunk/src/allmydata/mutable/retrieve.py",
> line 411, in _setup_encoding_parameters
>     assert start < self._num_segments
> exceptions.AssertionError:
> }}}

New description:

 {{{
 Traceback (most recent call last):
   File
 "/home/davidsarah/tahoe/git/trunk/src/allmydata/mutable/filenode.py", line
 990, in <lambda>
     self._serializer.addCallback(lambda ignore: cb(*args, **kwargs))
   File
 "/home/davidsarah/tahoe/git/trunk/src/allmydata/mutable/filenode.py", line
 980, in _read
     d = r.download(consumer, offset, size)
   File
 "/home/davidsarah/tahoe/git/trunk/src/allmydata/mutable/retrieve.py", line
 244, in download
     self._setup_encoding_parameters()
   File
 "/home/davidsarah/tahoe/git/trunk/src/allmydata/mutable/retrieve.py", line
 411, in _setup_encoding_parameters
     assert start < self._num_segments
 exceptions.AssertionError:
 }}}

 There are at least two bare asserts, one for the start segment and one for
 the end segment.

--

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2462#comment:1>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage