[tahoe-lafs-trac-stream] [Tahoe-LAFS] #2462: remove bare asserts for segment out-of-range errors in mutable retrieve

[Tahoe-LAFS]

#2462: remove bare asserts for segment out-of-range errors in mutable retrieve
-------------------------+-------------------------------------------------
     Reporter:  daira    |      Owner:  daira
         Type:  defect   |     Status:  assigned
     Priority:  normal   |  Milestone:  1.11.0
    Component:  code-    |    Version:  1.10.1
  mutable                |   Keywords:  cleanup error mutable retrieve
   Resolution:           |  download
Launchpad Bug:           |
-------------------------+-------------------------------------------------

Comment (by daira):

 Replying to [comment:3 daira]:
 > The current error behaviour is confusing; it appears that you can read
 one byte past the end of the file, only if the file is not a multiple of
 `k` bytes (i.e. at this API layer, you can read the dummy bytes that are
 added to make the size of the input to encoding a multiple of `k` bytes).

 See [https://github.com/tahoe-lafs/tahoe-
 lafs/commit/e437bfd64bf4fb6838036fde9aa05f987f911320#diff-
 8d5163da85905f8ddd5ce6a535206479R3403], which reads one byte past the end
 of the file, and passes. (The same thing happens when reading 101 bytes of
 a 100-byte SDMF file.) The explanation above may not be correct, though;
 it's just a guess.

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2462#comment:4>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage