[tahoe-lafs-trac-stream] [Tahoe-LAFS] #2427: Magic Folder on Linux: handle case when directory is removed from monitored directory

[Tahoe-LAFS]

#2427: Magic Folder on Linux: handle case when directory is removed from monitored
directory
-------------------------------------+-------------------------------------
     Reporter:  dawuud               |      Owner:  dawuud
         Type:  defect               |     Status:  new
     Priority:  normal               |  Milestone:  1.11.0
    Component:  code-frontend-       |    Version:  1.10.0
  magic-folder                       |   Keywords:  test-needed otf-magic-
   Resolution:                       |  folder-objective4
Launchpad Bug:                       |
-------------------------------------+-------------------------------------
Changes (by daira):

 * owner:  daira => dawuud


Comment:

 Remember that we removed the `autoAdd=True` argument from the calls to
 `watch`, in [https://github.com/david415/tahoe-
 lafs/commit/e57645a9f15a7223eb33984cdd495a55b246e474]. We did this because
 we believed that adding the extra call to `watch` in `_addDir`
 ([https://github.com/david415/tahoe-
 lafs/commit/e57645a9f15a7223eb33984cdd495a55b246e474#diff-
 d8c61dbeca89240ad731932115de07d7R185 here]) was the correct way to handle
 directories being moved into the monitored directory tree, since we had
 found that `autoAdd` does not add a watch in that case.

 It's likely that the problem is in that code; I would suggest adding a
 `print` to make sure that `watch` is being called for the moved-in
 directory, and with the correct arguments.

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2427#comment:12>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage