[tahoe-lafs-trac-stream] [Tahoe-LAFS] #2444: Magic Folder: tests fail on Travis-CI with UnicodeEncodeError from INotify.watch

[Tahoe-LAFS]

#2444: Magic Folder: tests fail on Travis-CI with UnicodeEncodeError from
INotify.watch
-------------------------------------+-------------------------------------
     Reporter:  daira                |      Owner:  daira
         Type:  defect               |     Status:  assigned
     Priority:  normal               |  Milestone:  undecided
    Component:  code-frontend-       |    Version:  1.10.0
  magic-folder                       |   Keywords:  otf-magic-folder-
   Resolution:                       |  objective4 tests unicode travis
Launchpad Bug:                       |
-------------------------------------+-------------------------------------

Comment (by daira):

 Replying to [comment:6 daira]:
 > There are actually two bugs here, one in Tahoe-LAFS (we should not be
 attempting to test Unicode filenames that the filesystem encoding can't
 represent), and the one in Twisted. The latter only causes a test failure
 on the branches of Tahoe-LAFS that have Windows inotify-emulation support
 enabled (because only those branches use Unicode-mode `FilePath`s).

 Correction: I had already fixed the first bug on those branches. The
 remaining problem is that we have this code in `encodingutil.py` which
 attempts to determine whether a Unicode-mode `FilePath` should be used:
 {{{
 use_unicode_filepath = sys.platform == "win32" or hasattr(FilePath,
 '_asTextPath')
 }}}

 Because of the Twisted bug, for now this needs to be just:
 {{{
 use_unicode_filepath = sys.platform == "win32"
 }}}

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2444#comment:7>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage