[tahoe-lafs-trac-stream] [zfec] #14: [patch] Make streaming from stdin / to stdout work.

zfec trac at tahoe-lafs.org
Sun Mar 1 19:30:16 UTC 2015


#14: [patch] Make streaming from stdin / to stdout work.
------------------------------+---------------------------
     Reporter:  ericpollmann  |      Owner:  zooko
         Type:  defect        |     Status:  new
     Priority:  major         |  Milestone:
    Component:  component1    |    Version:
   Resolution:                |   Keywords:  review-needed
Launchpad Bug:                |
------------------------------+---------------------------

Comment (by davidsarah):

 I reviewed [attachment:zfec-1.4.24-streaming-new.patch] (without testing
 it) and it looks good, including the tests.

 Review question:
 * Is `sys.stdin.name` documented to be `"<stdin>"`, or is that a CPython
 standard library implementation detail? Perhaps use
 `args.inputfile.fileno() == 0` (or `args.inputfile.fileno() ==
 sys.stdin.fileno()` which should be equivalent)?

--
Ticket URL: <https://tahoe-lafs.org/trac/zfec/ticket/14#comment:5>
zfec <https://tahoe-lafs.org/trac/zfec>
efficient erasure-coding library


More information about the tahoe-lafs-trac-stream mailing list