[tahoe-lafs-trac-stream] [Tahoe-LAFS] #2329: cp -r stops with an exception
Tahoe-LAFS
trac at tahoe-lafs.org
Tue Mar 3 10:30:48 UTC 2015
#2329: cp -r stops with an exception
-------------------------+-------------------------------------------------
Reporter: zooko | Owner: warner
Type: defect | Status: assigned
Priority: major | Milestone: 1.10.1
Component: code- | Version: 1.10.0
frontend-cli | Keywords: regression tahoe-cp review-needed
Resolution: | release-blocker
Launchpad Bug: |
-------------------------+-------------------------------------------------
Comment (by warner):
Ok, the patch is ready for review: https://github.com/tahoe-lafs/tahoe-
lafs/pull/143 . I rewrote the target-assignment code, cleaning up an awful
lot in the process. I tried to make the diff as minimal as possible, but
it may still look a bit ugly. The core 100-line cluster of functions was
replaced by a different 100-line cluster of functions, but there's enough
overlap that 'git diff' tries too hard to show you line-by-line changes,
and does it badly. My best advice for reviewing it is to print out those
100 lines before, and those 100 lines after, and compare those two
printouts, instead of looking at a detailed diff.
--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2329#comment:45>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage
More information about the tahoe-lafs-trac-stream
mailing list