[tahoe-lafs-trac-stream] [Tahoe-LAFS] #2312: DeprecationWarning about passing non-bytes header values

[Tahoe-LAFS]

#2312: DeprecationWarning about passing non-bytes header values
------------------------+---------------------------------------------
     Reporter:  daira   |      Owner:  warner
         Type:  defect  |     Status:  new
     Priority:  minor   |  Milestone:  1.10.1
    Component:  code    |    Version:  1.10.0
   Resolution:          |   Keywords:  DeprecationWarning cygwin tests
Launchpad Bug:          |
------------------------+---------------------------------------------

Comment (by warner):

 Nevow bug filed: https://github.com/twisted/nevow/issues/52 . (oh, as I
 reported earlier in comment:6, nevermind).

 Buildbot is now scanning for deprecation warnings, https://tahoe-lafs.org
 /buildbot-tahoe-
 lafs/builders/Ubuntu%20trusty%2014.04/builds/45/steps/deprecations/logs/warnings
 has a list. This is a simple regexp scan, so some of the lines are coming
 from the tests that fail (due to stderr not being as quiet as it's
 supposed to be):

 {{{
 /home/bb-tahoe/bb-tahoe/Ubuntu_trusty_14_04/build/support/lib/python2.7
 /site-packages/Nevow-0.11.1-py2.7.egg/nevow/appserver.py:129:
 DeprecationWarning: twisted.web.http.Request.received_headers was
 deprecated in Twisted 13.2.0: Please use
 twisted.web.http.Request.requestHeaders instead.
 /usr/lib/python2.7/dist-packages/twisted/web/server.py:217:
 DeprecationWarning: Passing non-bytes header values is deprecated since
 Twisted 12.3. Pass only bytes instead.
 a = '/usr/lib/python2.7/dist-packages/twisted/spread/jelly.py:92:
 DeprecationWarning: the sets module is deprecated\n  import sets as
 _sets\n'
 twisted.trial.unittest.FailTest: ('allmydata-tahoe: 1.10.0.post287
 [master: 681eb4d12e20d8818ee02baab7b55230a706e76d]\nfoolscap:
 0.6.4\npycryptopp:
 0.6.0.1206569328141510525648634803928199668821045408958\nzfec:
 1.4.5\nTwisted: 13.2.0\nNevow: 0.11.1\nzope.interface: unknown\npython:
 2.7.6\nplatform: Linux-Ubuntu_14.04-x86_64-32bit_ELF\npyOpenSSL:
 0.13\nsimplejson: 3.3.1\npycrypto: 2.6.1\npyasn1: 0.1.7\nmock:
 1.0.1\nsetuptools: 0.6c16dev5\nservice-identity: 14.0.0\ncharacteristic:
 14.3.0\npyasn1-modules: 0.0.5\n\n', '/usr/lib/python2.7/dist-
 packages/twisted/spread/jelly.py:92: DeprecationWarning: the sets module
 is deprecated\n  import sets as _sets\n', 0)
 twisted.trial.unittest.FailTest: cc=0, OUT: '', ERR: '/usr/lib/python2.7
 /dist-packages/twisted/spread/jelly.py:92: DeprecationWarning: the sets
 module is deprecated
 }}}

 So there are three real warnings:

 * nevow/appserver.py:129: "twisted.web.http.Request.received_headers was
 deprecated in Twisted 13.2.0"
 * twisted/web/server.py:217: "Passing non-bytes header values is
 deprecated since Twisted 12.3"
 * twisted/spread/jelly.py:92: "the sets module is deprecated; import sets
 as _sets"

 The first is filed as https://github.com/twisted/nevow/issues/53 , and the
 second as https://github.com/twisted/nevow/issues/52 . I don't know if the
 third is filed anywhere.

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2312#comment:15>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage