[tahoe-lafs-trac-stream] [Tahoe-LAFS] #2433: dead code: NamedTemporaryDirectory
Tahoe-LAFS
trac at tahoe-lafs.org
Tue May 26 17:20:03 UTC 2015
#2433: dead code: NamedTemporaryDirectory
---------------------+---------------------------
Reporter: zooko | Owner: daira
Type: defect | Status: new
Priority: normal | Milestone: undecided
Component: unknown | Version: 1.10.0
Keywords: | Launchpad Bug:
---------------------+---------------------------
Looking at #2432, I noticed that
[source:trunk/src/allmydata/util/fileutil.py?annotate=blame&rev=143af6151800efd8ecb750e682aa42da254ce5a7#L90
NamedTemporaryDirectory] is unused except for
[source:trunk/src/allmydata/test/test_util.py?annotate=blame&rev=4794666df619fbfd7d36620163b51bda31322773#L434
its unit test].
Now, [https://tahoe-lafs.org/trac/tahoe-
lafs/browser/trunk/src/allmydata/test/test_util.py?annotate=blame&rev=4794666df619fbfd7d36620163b51bda31322773#L434
the newer version of NamedTemporaryDirectory] over in pyutil has an added
feature — automatically call `.close()` on children when shutting down —
which might be useful on Windows, but probably isn't. In any case, let's
remove this older and unused version of `NamedTemporaryDirectory` from
Tahoe-LAFS™.
--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2433>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage
More information about the tahoe-lafs-trac-stream
mailing list