[tahoe-lafs-trac-stream] [Tahoe-LAFS] #2500: teach magic-folder unit tests to time travel
Tahoe-LAFS
trac at tahoe-lafs.org
Mon Oct 5 09:09:28 UTC 2015
#2500: teach magic-folder unit tests to time travel
-------------------------------------+-------------------------------------
Reporter: dawuud | Owner: daira
Type: defect | Status: new
Priority: normal | Milestone: undecided
Component: code-frontend- | Version: 1.10.1
magic-folder | Keywords: otf-magic-folder-
Resolution: | objective4
Launchpad Bug: |
-------------------------------------+-------------------------------------
Comment (by daira):
Replying to [comment:6 daira]:
> Reviewing [https://github.com/tahoe-lafs/tahoe-lafs/pull/191].
Thanks meejah, but I think there should be a less disruptive way of
solving this. The approach in this commit makes me nervous because it's
effectively testing different code than actually runs in production. It
should be possible to just set the 'processed' hook earlier if the problem
is as described in the [https://github.com/meejah/tahoe-
lafs/commit/73bf4ad11b21b05e6041ad037b0763335f826338#diff-
bb1f5d18cb222223564b05efa0b402d2R375 comment at line 375 of
test_magic_folder.py].
So, -1 on the review.
--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2500#comment:7>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage
More information about the tahoe-lafs-trac-stream
mailing list