[tahoe-lafs-trac-stream] [Tahoe-LAFS] #2502: consider switching from 'verlib' to 'packaging' for version checks

[Tahoe-LAFS]

#2502: consider switching from 'verlib' to 'packaging' for version checks
---------------------------------------+---------------------------
 Reporter:  daira                      |          Owner:  daira
     Type:  task                       |         Status:  new
 Priority:  normal                     |      Milestone:  undecided
Component:  packaging                  |        Version:  1.10.1
 Keywords:  verlib packaging versions  |  Launchpad Bug:
---------------------------------------+---------------------------
 dstufft: daira: you're using verlib? You probably want to use
 https://warehouse.python.org/project/packaging/

 daira: dstufft: yes, it was what was available at the time

 dstufft: yea makes sense

 daira: is there a compelling reason to switch?

 daira: I guess we could use https://pypi.python.org/pypi/packaging rather
 than copying the code as we did with verlib...

 daira: except that how do we check the version of the 'packaging'
 dependency in that case?

 daira: I think I'd rather leave this well alone

 dstufft: daira: the reason you're getting a None [in #2499] is that verlib
 doesn't support PEP 440 and your version it was passing into it was a PEP
 440 version

 dstufft: that's the root cause of that error

 daira: ah

 daira: so that is potentially a good reason to switch

 daira: if more packages are going to start using only-PEP-440-compatible
 versions

 dstufft: packaging is designed to either be put as a dependency OR bundled
 directly

 dstufft: it has no (and will never have) any dependencies of it's own, and
 is only pure python

 dstufft: both pip and setuptools are using it now (bundled)

 daira: I see

 daira: I think we can bundle it then

 daira: I'll file a ticket

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2502>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage