[tahoe-lafs-trac-stream] [Tahoe-LAFS] #2507: consider whether to use @inlineCallbacks (in tests or more generally)

[Tahoe-LAFS]

#2507: consider whether to use @inlineCallbacks (in tests or more generally)
-------------------------+-----------------------
     Reporter:  daira    |      Owner:  daira
         Type:  defect   |     Status:  assigned
     Priority:  normal   |  Milestone:  undecided
    Component:  unknown  |    Version:  1.10.1
   Resolution:           |   Keywords:
Launchpad Bug:           |
-------------------------+-----------------------
Changes (by daira):

 * status:  new => assigned


Old description:

> [09:05] <daira1> meejah: we don't use inlineCallbacks in Tahoe mainly due
> to inertia -- the vast majority of the codebase was written without
> them...
> [09:07] <daira1> I had some minor technical reservations about them (and
> about mixing the two styles) but I should probably reconsider whether
> those are really justified
> [09:09] <daira1> currently our only use of them is in the tests for some
> of the cloud backend service providers (on a dev branch) that Leif wrote
> [09:10] <daira1> I think there's no objection to using them more
> generally in tests
>
> For this ticket, understand pros and cons of using @inlineCallbacks and
> add a section to the CodingStandards with guidelines for their use. (This
> might be very short if no guidelines are needed!)

New description:

 <daira> meejah: we don't use inlineCallbacks in Tahoe mainly due to
 inertia -- the vast majority of the codebase was written without them...
 <daira> I had some minor technical reservations about them (and about
 mixing the two styles) but I should probably reconsider whether those are
 really justified
 <daira> currently our only use of them is in the tests for some of the
 cloud backend service providers (on a dev branch) that Leif wrote
 <daira> I think there's no objection to using them more generally in tests

 For this ticket, understand pros and cons of using @inlineCallbacks and
 add a section to the CodingStandards with guidelines for their use. (This
 might be very short if no guidelines are needed!)

--

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2507#comment:1>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage