[tahoe-lafs-trac-stream] [Tahoe-LAFS] #2771: upcoming deprecation in webish.py

[Tahoe-LAFS]

#2771: upcoming deprecation in webish.py
-------------------------------+---------------------------
 Reporter:  warner             |          Owner:
     Type:  defect             |         Status:  new
 Priority:  normal             |      Milestone:  undecided
Component:  code-frontend-web  |        Version:  1.11.0
 Keywords:  nevow twisted      |  Launchpad Bug:
-------------------------------+---------------------------
 Our shiny new [https://tahoe-lafs.org/buildbot-tahoe-
 lafs/builders/deprecations deprecations builder] is running Tahoe tests
 against git trunk for both Twisted and Foolscap. It's yielded our first
 early warning signs:

 {{{
 .../allmydata/webish.py:44: DeprecationWarning:
 twisted.web.http.Request.channel was deprecated in Twisted 16.2.0. Call
 directly into the Request object instead.
 .../allmydata/webish.py:45: DeprecationWarning:
 twisted.web.http.Request.channel was deprecated in Twisted 16.2.0. Call
 directly into the Request object instead.
 .../nevow/appserver.py:229: DeprecationWarning:
 twisted.web.http.Request.channel was deprecated in Twisted 16.2.0. Call
 directly into the Request object instead.
 }}}

 It looks like our cut/paste/override copy of
 twisted.web.http.Request.requestReceived is out of date, and is using
 things that Twisted will be deprecating in the next release (the current
 release, 16.1.0, doesn't produce complaints).

 Nominally we could just make our local `requestReceived` method look more
 like Twisted's current copy (in this case, changing `self.client =
 self.channel.transport.getPeer()` into `= self._channel.getPeer()`), but
 it might be good to rethink this, and find a way to get rid of our custom
 subclass. Especially because then we'd be using a clearly-marked-as-
 private attribute.

 This might also tie into removing Nevow (#1963).

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2771>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage