[tahoe-lafs-trac-stream] [Tahoe-LAFS] #2808: scan for defer.setDebugging(True)

[Tahoe-LAFS]

#2808: scan for defer.setDebugging(True)
-------------------------+----------------------------
 Reporter:  warner       |          Owner:
     Type:  enhancement  |         Status:  new
 Priority:  normal       |      Milestone:  eventually
Component:  code         |        Version:  1.11.0
 Keywords:               |  Launchpad Bug:
-------------------------+----------------------------
 While investigating problems, we frequently turn on
 `defer.setDebugging(True)` temporarily. This records stack traces inside
 Deferreds (both the trace leading up to creation, and the one leading up
 to the first callback/errback invocation).

 Unfortunately this slows things down considerably, and sometimes we forget
 to turn this back off before committing new code. I think we've done this
 three or four times so far. The most recent time was a few weeks ago, when
 the magic-folders code landed with Deferred debugging turned on. Meejah
 just noticed it and fixed it in [054efe0] today.

 We should write some automated test that scans the codebase for
 `defer.setDebugging(True)` and flunks the tests if it's found. Something
 in the `code-checks` run, the one where we look for duplicate `umid`
 values, or mis-captured local variables, or pyflakes failures.

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2808>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage