[tahoe-lafs-trac-stream] [Tahoe-LAFS] #2816: make sure tub.location and tub.port can be empty

[Tahoe-LAFS]

#2816: make sure tub.location and tub.port can be empty
--------------------------------+----------------------
     Reporter:  warner          |      Owner:  warner
         Type:  task            |     Status:  reopened
     Priority:  normal          |  Milestone:  1.12.0
    Component:  code-nodeadmin  |    Version:  1.11.0
   Resolution:                  |   Keywords:
Launchpad Bug:                  |
--------------------------------+----------------------

Comment (by warner):

 Reminding myself what the valid combinations are:

 ||= tub.port =||||||||= tub.location =||
 ||            || missing    || empty || "disabled" || hintstring ||
 || missing    || alloc/auto || ERR2  || ERR4       || alloc/file ||
 || empty      || ERR1       || ERR1  || ERR1       || ERR1       ||
 || "disabled" || ERR3       || ERR2  || no-listen  || ERR3       ||
 || endpoint   || auto       || ERR2  || ERR4       || manual     ||

 * ERR1: tub.port is not allowed to be an empty string
 * ERR2: tub.location is not allowed to be an empty string
 * ERR3: if tub.port is "disabled", tub.location must be too
 * ERR4: if tub.location is "disabled", tub.port must be too
 * alloc/auto: (legacy default): tub.port is either read from the portfile
 (e.g. NODEDIR/client.port), or allocated (and then written into the
 portfile). tub.location is automatically set by scanning for addresses and
 combining with the port number
 * auto: tub.port comes from tahoe.cfg, and must be in the form `tcp:12345`
 or `tcp:12345:morestuff`. tub.location is automatically set as above
 * manual: both tub.port and tub.location are specified in tahoe.cfg,
 although tub.location can contain `AUTO`, which is treated as above
 * alloc/file: tub.port is either read from portfile or allocated.
 tub.location is set by tahoe.cfg, but can contain `AUTO`
 * no-listen: the Tub does not run a Listener, and does not have a location

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2816#comment:8>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage