[tahoe-lafs-trac-stream] [Tahoe-LAFS] #2663: spurious failure in test_web.Web.test_welcome* with Nevow 0.12.0/Twisted 15.5.0

[Tahoe-LAFS]

#2663: spurious failure in test_web.Web.test_welcome* with Nevow 0.12.0/Twisted
15.5.0
----------------------------------+----------------------------------------
     Reporter:  daira             |      Owner:
         Type:  defect            |     Status:  new
     Priority:  major             |  Milestone:  1.10.3
    Component:  code-frontend-    |    Version:  1.10.2
  web                             |
   Resolution:                    |   Keywords:  tests nevow blocks-release
Launchpad Bug:                    |
----------------------------------+----------------------------------------

Comment (by leif):

 This is caused by this change in Nevow;
 https://github.com/twisted/nevow/commit/f88939ac957d6c2bfdcf5e91edd2baf1c4ae3c5d

 Attributes are now sorted. How should we fix this? Since pip-install users
 (which is what Travis CI does) will get 0.12, but Debian and Ubuntu users
 get 0.10 or 0.11, we probably want to support both.

 An easy fix would be to require Nevow 0.11, but this is obviously not a
 long-term solution.

 Another option would be to change all of the tests to actually parse the
 rendered HTML. This could require minimal changes to the tests themselves;
 simply replacing `failUnlessIn` with (the as-yet unwritten but easy to
 write) `failUnlessXmlIn`. I don't think we currently have an HTML parser
 in our dependencies, though.

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2663#comment:4>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage