[tahoe-lafs-trac-stream] [Tahoe-LAFS] #2535: Magic Folder: permissions of downloaded files should be set in a more failure-safe way

[Tahoe-LAFS]

#2535: Magic Folder: permissions of downloaded files should be set in a more
failure-safe way
-------------------------------------+-------------------------------------
     Reporter:  dawuud               |      Owner:  daira
         Type:  defect               |     Status:  new
     Priority:  normal               |  Milestone:  undecided
    Component:  code-frontend-       |    Version:  1.10.1
  magic-folder                       |   Keywords:  magic-folder
   Resolution:                       |  permissions security usability unix
Launchpad Bug:                       |  docs-needed
-------------------------------------+-------------------------------------

Comment (by meejah):

 Looks good to me. Two questions

  - where does `self._local_path_u` come from (i.e. should that be
 local_path_u instead?)
  - i would maybe call the `local_path_u` arg to `_write_downloaded_file`
 `workdir_u` or similar to match the arg name at the callsite (and also to
 avoid confusion to `self._local_path_u` if that isn't a typo)
  - `while` loops make me nervous ;) but that one looks fine

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2535#comment:24>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage