[tahoe-lafs-trac-stream] [Tahoe-LAFS] #2731: Magic Folder: miscounting in magic_folder.uploader.objects_queued

[Tahoe-LAFS]

#2731: Magic Folder: miscounting in magic_folder.uploader.objects_queued
-------------------------------------+-------------------------------------
     Reporter:  daira                |      Owner:  daira
         Type:  defect               |     Status:  new
     Priority:  normal               |  Milestone:  undecided
    Component:  code-frontend-       |    Version:  1.10.2
  magic-folder                       |   Keywords:  magic-folder error
   Resolution:                       |  statistics blocks-merge
Launchpad Bug:                       |
-------------------------------------+-------------------------------------

Comment (by dawuud):

 using only the unit tests i was able to find evidence that at least the
 Downloader is affected by this bug:
 {{{
 (virtenv-tahoe-lafs)user at tahoe-dev:~/tahoe-lafs$ grep 'now \-1' ,1 | wc -l
 28
 (virtenv-tahoe-lafs)user at tahoe-dev:~/tahoe-lafs$ grep 'now \-1' ,1
 Magic Folder 'client-1' downloader: objects_queued += -1 (now -1)
 Magic Folder 'client-1' downloader: objects_queued += 0 (now -1)
 Magic Folder 'client-0' downloader: objects_queued += -1 (now -1)
 Magic Folder 'client-0' downloader: objects_queued += 0 (now -1)
 Magic Folder 'client-0' downloader: objects_queued += 0 (now -1)
 Magic Folder 'client-0' downloader: objects_queued += 0 (now -1)
 Magic Folder 'client-1' downloader: objects_queued += -1 (now -1)
 Magic Folder 'client-1' downloader: objects_queued += 0 (now -1)
 Magic Folder 'client-0' downloader: objects_queued += -1 (now -1)
 Magic Folder 'client-1' downloader: objects_queued += -1 (now -1)
 Magic Folder 'client-1' downloader: objects_queued += -1 (now -1)
 Magic Folder 'client-0' downloader: objects_queued += -1 (now -1)
 Magic Folder 'client-1' downloader: objects_queued += -1 (now -1)
 Magic Folder 'client-0' downloader: objects_queued += -1 (now -1)
 Magic Folder 'client-1' downloader: objects_queued += -1 (now -1)
 Magic Folder 'client-1' downloader: objects_queued += -1 (now -1)
 Magic Folder 'client-0' downloader: objects_queued += -1 (now -1)
 Magic Folder 'client-0' downloader: objects_queued += 0 (now -1)
 Magic Folder 'client-0' downloader: objects_queued += 0 (now -1)
 Magic Folder 'client-0' downloader: objects_queued += 0 (now -1)
 Magic Folder 'client-1' downloader: objects_queued += -1 (now -1)
 Magic Folder 'client-1' downloader: objects_queued += 0 (now -1)
 Magic Folder 'client-0' downloader: objects_queued += -1 (now -1)
 Magic Folder 'client-1' downloader: objects_queued += -1 (now -1)
 Magic Folder 'client-1' downloader: objects_queued += -1 (now -1)
 Magic Folder 'client-0' downloader: objects_queued += -1 (now -1)
 Magic Folder 'client-1' downloader: objects_queued += -1 (now -1)
 Magic Folder 'client-1' downloader: objects_queued += -1 (now -1)
 }}}

 i theorize this happens because directories are added to the deque as a
 single item and the child are decremented individually cause the negative
 count.

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2731#comment:2>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage