[tahoe-lafs-trac-stream] [Tahoe-LAFS] #1168: make setup.py more easily patchable by OS packagers

[Tahoe-LAFS]

#1168: make setup.py more easily patchable by OS packagers
----------------------------+----------------------------------------------
     Reporter:  davidsarah  |      Owner:  zooko
         Type:  defect      |     Status:  closed
     Priority:  normal      |  Milestone:  1.11.0
    Component:  packaging   |    Version:  1.8β
   Resolution:  fixed       |   Keywords:  install setuptools debian ubuntu
Launchpad Bug:              |
----------------------------+----------------------------------------------
Changes (by warner):

 * status:  assigned => closed
 * resolution:   => fixed
 * milestone:  undecided => 1.11.0


Old description:

> Packaging Tahoe-LAFS for OS distributions (e.g. Debian or Ubuntu)
> currently requires that [source:setup.py] be patched, so that setuptools
> doesn't try to satisfy Tahoe's dependencies by downloading eggs or by
> deciding to use a different version of the dependency than would be
> provided by an OS package.
>
> The attached diff adds an {{{external_dependency_management}}} switch to
> {{{setup.py}}} to cause this change in behaviour. It doesn't remove the
> need for a patch, but makes such patches much more likely to apply
> cleanly.

New description:

 Packaging Tahoe-LAFS for OS distributions (e.g. Debian or Ubuntu)
 currently requires that [source:setup.py] be patched, so that setuptools
 doesn't try to satisfy Tahoe's dependencies by downloading eggs or by
 deciding to use a different version of the dependency than would be
 provided by an OS package.

 The attached diff adds an {{{external_dependency_management}}} switch to
 {{{setup.py}}} to cause this change in behaviour. It doesn't remove the
 need for a patch, but makes such patches much more likely to apply
 cleanly.

--

Comment:

 I think our new setup.py now meets this requirement. At least, it behaves
 like all other setup.pys out there. The lack of `setup_requires=` is a big
 one, and using `tox` for tests means we no longer have custom `setup.py
 test` steps (with dependencies).

 Closing this one out, but feel free to re-open if I've misinterpreted it.

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1168#comment:17>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage