[tahoe-lafs-trac-stream] [Tahoe-LAFS] #2829: make magic-folder (downloader) polling interval configurable

[Tahoe-LAFS]

#2829: make magic-folder (downloader) polling interval configurable
--------------------------------------------+--------------------
     Reporter:  meejah                      |      Owner:  meejah
         Type:  defect                      |     Status:  new
     Priority:  normal                      |  Milestone:  1.12.0
    Component:  code-frontend-magic-folder  |    Version:  1.11.0
   Resolution:                              |   Keywords:
Launchpad Bug:                              |
--------------------------------------------+--------------------

Comment (by dawuud):

 upon looking at the code more closely i don't understand why we have two
 delay variables in the queue mixin:

 1. turn delay
 2. scan interval

 the scan interval only controls how often when_queue_is_empty is called
 which is only used by the Downloader which performs a remote collective
 dir scan every scan interval. having the scan interval and the turn delay
 be different for the Downloader does nothing special.

 the uploader doesn't even use when_queue_is_empty. it's a no-op.

 can we get rid of scan_interval?
 I certainly do not like shadowing variable in mixins and in the inheriting
 class.

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2829#comment:4>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage