[tahoe-lafs-trac-stream] [Tahoe-LAFS] #2773: `tahoe create-node` should require `--location` and/or `--hostname`, and not autodetect
Tahoe-LAFS
trac at tahoe-lafs.org
Fri Sep 2 17:02:20 UTC 2016
#2773: `tahoe create-node` should require `--location` and/or `--hostname`, and
not autodetect
--------------------------------+----------------------
Reporter: warner | Owner: warner
Type: task | Status: assigned
Priority: normal | Milestone: 1.13.0
Component: code-nodeadmin | Version: 1.11.0
Resolution: | Keywords:
Launchpad Bug: |
--------------------------------+----------------------
Comment (by warner):
The first step is probably to change the create-node functions to be
async, which means changing `runner.py` to accept a Deferred back from the
dispatch function, and spin up a reactor, and wait for the Deferred to
finish before shutting it down and returning the exit code. Twisted has a
utility for this `twisted.internet.task.react()`, which I'm using in
magic-wormhole, although it calls `sys.exit(rc)` itself, so we might only
want to use it in the run-by-human=true path.
Second step is to add --location/--port. Third is to add --listen=tcp.
Fourth is to implement --listen=tor or i2p.
Although we could put off the async create-node until just before
implementing --listen=tor, because we've got a synchronous
`allmydata.util.iputil.allocate_tcp_port()`.
--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2773#comment:11>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage
More information about the tahoe-lafs-trac-stream
mailing list