[tahoe-lafs-trac-stream] [Tahoe-LAFS] #2824: allow `[connections] tcp = none` ?

[Tahoe-LAFS]

#2824: allow `[connections] tcp = none` ?
--------------------------------+-------------------------------
     Reporter:  warner          |      Owner:  warner
         Type:  defect          |     Status:  reopened
     Priority:  normal          |  Milestone:  1.12.0
    Component:  code-nodeadmin  |    Version:  1.11.0
   Resolution:                  |   Keywords:  anonymity tor i2p
Launchpad Bug:                  |
--------------------------------+-------------------------------
Changes (by str4d):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 There is still a usability issue: if the user forgets to set
 `connections:tcp=disabled`, the resulting error does not inform them of
 this, instead telling them to enable Tor.

 {{{
 STARTING '/home/str4d/dev/tahoe/test-storage'
 starting node in '/home/str4d/dev/tahoe/test-storage'
 Traceback (most recent call last):
   File "/home/str4d/dev/tahoe/tahoe-lafs/venv-storage/local/lib/python2.7
 /site-packages/Twisted-16.4.1-py2.7-linux-
 x86_64.egg/twisted/internet/defer.py", line 317, in addCallback
     callbackKeywords=kw)
   File "/home/str4d/dev/tahoe/tahoe-lafs/venv-storage/local/lib/python2.7
 /site-packages/Twisted-16.4.1-py2.7-linux-
 x86_64.egg/twisted/internet/defer.py", line 306, in addCallbacks
     self._runCallbacks()
   File "/home/str4d/dev/tahoe/tahoe-lafs/venv-storage/local/lib/python2.7
 /site-packages/Twisted-16.4.1-py2.7-linux-
 x86_64.egg/twisted/internet/defer.py", line 587, in _runCallbacks
     current.result = callback(current.result, *args, **kw)
   File "/home/str4d/dev/tahoe/tahoe-lafs/src/allmydata/scripts/runner.py",
 line 145, in dispatch
     d = defer.maybeDeferred(f, so)
 --- <exception caught here> ---
   File "/home/str4d/dev/tahoe/tahoe-lafs/venv-storage/local/lib/python2.7
 /site-packages/Twisted-16.4.1-py2.7-linux-
 x86_64.egg/twisted/internet/defer.py", line 149, in maybeDeferred
     result = f(*args, **kw)
   File "/home/str4d/dev/tahoe/tahoe-
 lafs/src/allmydata/scripts/startstop_node.py", line 170, in start
     twistd.runApp(twistd_config)
   File "/home/str4d/dev/tahoe/tahoe-lafs/venv-storage/local/lib/python2.7
 /site-packages/Twisted-16.4.1-py2.7-linux-
 x86_64.egg/twisted/scripts/twistd.py", line 25, in runApp
     _SomeApplicationRunner(config).run()
   File "/home/str4d/dev/tahoe/tahoe-lafs/venv-storage/local/lib/python2.7
 /site-packages/Twisted-16.4.1-py2.7-linux-
 x86_64.egg/twisted/application/app.py", line 379, in run
     self.application = self.createOrGetApplication()
   File "/home/str4d/dev/tahoe/tahoe-lafs/venv-storage/local/lib/python2.7
 /site-packages/Twisted-16.4.1-py2.7-linux-
 x86_64.egg/twisted/application/app.py", line 439, in
 createOrGetApplication
     ser = plg.makeService(self.config.subOptions)
   File "/home/str4d/dev/tahoe/tahoe-
 lafs/src/allmydata/scripts/startstop_node.py", line 78, in makeService
     return Client(self.basedir)
   File "/home/str4d/dev/tahoe/tahoe-lafs/src/allmydata/client.py", line
 179, in __init__
     node.Node.__init__(self, basedir)
   File "/home/str4d/dev/tahoe/tahoe-lafs/src/allmydata/node.py", line 141,
 in __init__
     self.init_connections()
   File "/home/str4d/dev/tahoe/tahoe-lafs/src/allmydata/node.py", line 315,
 in init_connections
     raise PrivacyError("tcp = tcp, must be set to 'tor'")
 allmydata.node.PrivacyError: tcp = tcp, must be set to 'tor'
 }}}

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2824#comment:4>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage