[tahoe-lafs-trac-stream] [Tahoe-LAFS] #2821: make "tahoe create-client --hide-ip" fail if txtorcon/txi2p are not installed

[Tahoe-LAFS]

#2821: make "tahoe create-client --hide-ip" fail if txtorcon/txi2p are not
installed
--------------------------------+---------------------------
     Reporter:  warner          |      Owner:  warner
         Type:  enhancement     |     Status:  assigned
     Priority:  normal          |  Milestone:  1.12.0
    Component:  code-nodeadmin  |    Version:  1.11.0
   Resolution:                  |   Keywords:  anonymity tor
Launchpad Bug:                  |
--------------------------------+---------------------------

Comment (by warner):

 Oh, I tried to write some tests for your branch, and I discovered that I
 was wrong about this needing to go into `init_connections()`. The #2820
 change makes `create-client --hide-ip` set `tcp = tor`, which then
 triggers an error at startup (`unavailable/unimportable handler type
 'tor'. Please pip install tahoe-lafs[tor] to fix.`), so we don't need a
 new error in `init_connections`(). (in the test I added, it kept bailing
 before the new error that you added)

 Instead, I think we need new code in `tahoe create-client`, to make
 `--hide-ip` try to import the !Foolscap/Tor connection handler, and give
 that same useful error message if it fails. This should probably be done
 as part of the #2490 "create-node-does-tor" changes.

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2821#comment:4>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage