[tahoe-lafs-trac-stream] [Tahoe-LAFS] #2910: updating setuptools with setup_requires causes build failure

[Tahoe-LAFS]

#2910: updating setuptools with setup_requires causes build failure
---------------------------+--------------------
     Reporter:  warner     |      Owner:  warner
         Type:  defect     |     Status:  new
     Priority:  normal     |  Milestone:  soon
    Component:  packaging  |    Version:  1.12.1
   Resolution:             |   Keywords:
Launchpad Bug:             |
---------------------------+--------------------

Comment (by Brian Warner <warner@…>):

 In [changeset:"526b97c7531e12e379f0c577bc15a07b5c2d6446/trunk"
 526b97c/trunk]:
 {{{
 #!CommitTicketReference repository="trunk"
 revision="526b97c7531e12e379f0c577bc15a07b5c2d6446"
 tox: add 'skipsdist=True', hoping this will fix buildbot

 There appears to be a bug in setuptools, triggered by running "python
 setup.py sdist" with setuptools==11.3 in that python's environment, on a
 project whose setup.py has a setup_requires= that requests setuptools >=
 28.8.0. When setuptools is upgraded from inside setup.py, it gets into a
 weird hybrid state where it's using setup() keyword-argument plugins from
 the
 newer setuptools, but those plugins reference functions that aren't
 present
 in the older setuptools, and the sdist command fails with an import
 error (module object has no attribute 'check_specifier').

 We don't actually need the sdist: all our tox test environments use
 "skip_install = true", because we install tahoe via the "deps" line (so we
 can get the `[test]` extra, and get a faster symlink-ish "editable"
 install).
 That install uses "pip", which uses the pip inside the new virtualenv,
 which
 either uses a newer version of setuptools (dependent upon what version of
 "virtualenv" was installed in the parent environment, next to tox) or
 somehow
 allows setuptools to be upgraded without exposing this weird broken hybrid
 state.

 Either way, skipping the sdist seems to fix this problem.

 refs ticket:2910
 https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2910
 }}}

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2910#comment:1>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage