[tahoe-lafs-trac-stream] [Tahoe-LAFS] #3052: Stop mutating tempfile.tempdir as a side-effect of creating a Node

[Tahoe-LAFS]

#3052: Stop mutating tempfile.tempdir as a side-effect of creating a Node
---------------------+---------------------------
 Reporter:  exarkun  |          Owner:
     Type:  defect   |         Status:  new
 Priority:  normal   |      Milestone:  undecided
Component:  code     |        Version:  n/a
 Keywords:           |  Launchpad Bug:
---------------------+---------------------------
 `Node.init_tempdir` sets `tempfile.tempdir` so that Twisted Web will write
 uploaded files to a node-specific directory.

 `tempfile.tempdir` is global state and mutating it for a particular `Node`
 instance causes all kinds of problems (for example, it means you can't
 really have two Node instances in one process; it also wreaks havoc on the
 test suite).

 Get a feature into Twisted so that Twisted Web doesn't rely on this global
 state for upload file location and then use that feature instead of
 mutating `tempfile.tempdir`.

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3052>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage