[tahoe-lafs-trac-stream] [Tahoe-LAFS] #2909: magic-folder .backup files are wrong

[Tahoe-LAFS]

#2909: magic-folder .backup files are wrong
--------------------------------------------+-----------------------
     Reporter:  meejah                      |      Owner:  daira
         Type:  defect                      |     Status:  closed
     Priority:  normal                      |  Milestone:  undecided
    Component:  code-frontend-magic-folder  |    Version:  1.12.1
   Resolution:  fixed                       |   Keywords:
Launchpad Bug:                              |
--------------------------------------------+-----------------------
Changes (by exarkun):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 It also looks like the `.backup` logic has changed.  Previously, thanks to
 https://github.com/tahoe-lafs/tahoe-
 lafs/blob/797932244da3036e0dd2463961a30cf2d319d99b/src/allmydata/frontends/magic_folder.py#L958,
 any non-conflicted file being written would result in a backup file,
 including the case described in this ticket's description.

 However, it looks like meejah fixed this behavior in
 47b17876339443145e95081e9581327229a6f064 by removing the `backup_path_u`
 argument to `fileutil.replace_file`.  This causes `fileutil.replace_file`
 to not create a backup file.  Thus, backups are only created when metadata
 indicates the new version of the file is a deletion.

 The merge for this was c9e00a988ae90ad5e63897607c70404974d370b2:

 {{{
 commit c9e00a988ae90ad5e63897607c70404974d370b2
 Merge: 458889682 541493018
 Author: meejah <meejah at meejah.ca>
 Date:   Tue May 1 15:52:10 2018 -0600

     Merge pull request #475 from meejah/2909.backup-behavior.0

     #2909 fix .backup file behavior and (some of) the incorrect .conflict
 cases (#2911)
 }}}

 Therefore, closing as fixed.

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2909#comment:3>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage