[tahoe-lafs-trac-stream] [Tahoe-LAFS] #3294: port allmydata.web.root.IncidentReporter to use twisted.web.template

[Tahoe-LAFS]

#3294: port allmydata.web.root.IncidentReporter to use twisted.web.template
-------------------------------+------------------------------
     Reporter:  sajith         |      Owner:  sajith
         Type:  defect         |     Status:  closed
     Priority:  normal         |  Milestone:  Support Python 3
    Component:  code-frontend  |    Version:  n/a
   Resolution:  fixed          |   Keywords:  python3 nevow
Launchpad Bug:                 |
-------------------------------+------------------------------
Changes (by Sajith Sasidharan <sajith@…>):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"a14cee5cce616a5490f64f1aa71ba9106c3e3270/trunk"
 a14cee5/trunk]:
 {{{
 #!CommitTicketReference repository="trunk"
 revision="a14cee5cce616a5490f64f1aa71ba9106c3e3270"
 Remove nevow from allmydata.web.root.IncidentReporter

 This change calls for an explanation:

 - `RenderMixin` doesn't seem to be adding anything here, so it is
    gone.

 - The web browser was unhappy without a charset in the response
   (Firefox 74 was anyway), so `content-type` header also gets a
   `charset=UTF-8`.

 - Returning a Unicode string made nevow appserver unhappy, so it is
   just a `str`.  The precise error message was:

   exceptions.TypeError: ('Could not adapt', u'An incident report has been
 saved to logs/incidents/ in the node directory.', <InterfaceClass
 nevow.inevow.IResource>)

 Fixes: ticket:3294
 }}}

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3294#comment:1>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage