[tahoe-lafs-trac-stream] [Tahoe-LAFS] #3515: The pre-commit push hook takes a long time to run

Tahoe-LAFS trac at tahoe-lafs.org
Thu Nov 19 16:00:24 UTC 2020


#3515: The pre-commit push hook takes a long time to run
-------------------------+-----------------------
     Reporter:  exarkun  |      Owner:
         Type:  defect   |     Status:  new
     Priority:  normal   |  Milestone:  undecided
    Component:  unknown  |    Version:  n/a
   Resolution:           |   Keywords:
Launchpad Bug:           |
-------------------------+-----------------------

Comment (by exarkun):

 Currently the hook runs `tox -e codechecks` which runs flake8 on all
 source files in the checkout.

 It seems like it would be good to run flake8 only on files being modified
 by changesets being pushed.  flake8 does no cross-source-file checking so
 there is no way for a change in file X to introduce a flake in file Y.  So
 checking only changed files seems safe.

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3515#comment:1>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage


More information about the tahoe-lafs-trac-stream mailing list