[tahoe-lafs-trac-stream] [Tahoe-LAFS] #3399: Evaluate adding mypy checks to code checks

Tahoe-LAFS trac at tahoe-lafs.org
Sun Nov 29 17:34:29 UTC 2020


#3399: Evaluate adding mypy checks to code checks
-----------------------------+------------------------------
     Reporter:  jaraco       |      Owner:
         Type:  enhancement  |     Status:  new
     Priority:  normal       |  Milestone:  Support Python 3
    Component:  unknown      |    Version:  n/a
   Resolution:               |   Keywords:
Launchpad Bug:               |
-----------------------------+------------------------------

Comment (by jaraco):

 Attempting to bisect these two behaviors, I'm first going to create a new
 environment and eliminate pip-run from the equation.

 {{{
 test $ python -m venv env
 test $ env/bin/pip install mypy-zope at git+https://github.com/jaraco/mypy-
 zope at bugfix/21-InterfaceClass-subclass foolscap at git+https://
 github.com/jaraco/foolscap at bugfix/75-use-metaclass
 Collecting mypy-zope@ git+https://github.com/jaraco/mypy-zope@bugfix/21
 -InterfaceClass-subclass
   Cloning https://github.com/jaraco/mypy-zope (to revision bugfix/21
 -InterfaceClass-subclass) to
 /private/var/folders/c6/v7hnmq453xb6p2dbz1gqc6rr0000gn/T/pip-install-
 77g6an3b/mypy-zope_f6b54b0e1c91451abed30cf7a1265976
 Collecting foolscap@ git+https://github.com/jaraco/foolscap@bugfix/75-use-
 metaclass
   Cloning https://github.com/jaraco/foolscap (to revision bugfix/75-use-
 metaclass) to /private/var/folders/c6/v7hnmq453xb6p2dbz1gqc6rr0000gn/T
 /pip-install-77g6an3b/foolscap_bb7193a6b86a4326b0d66ba21edbd79f
 Collecting mypy==0.790
   Using cached mypy-0.790-py3-none-any.whl (2.4 MB)
 Collecting mypy-extensions<0.5.0,>=0.4.3
   Using cached mypy_extensions-0.4.3-py2.py3-none-any.whl (4.5 kB)
 Collecting typed-ast<1.5.0,>=1.4.0
   Using cached typed_ast-1.4.1-cp39-cp39-macosx_10_15_x86_64.whl (225 kB)
 Collecting typing-extensions>=3.7.4
   Using cached typing_extensions-3.7.4.3-py3-none-any.whl (22 kB)
 Processing
 /Users/jaraco/Library/Caches/pip/wheels/e5/5c/53/f56b69010340b883474a456e8ee34b546e27f78f01b36701e3/Twisted-20.3.0-cp39-cp39-macosx_10_9_x86_64.whl
 Collecting constantly>=15.1
   Using cached constantly-15.1.0-py2.py3-none-any.whl (7.9 kB)
 Collecting service-identity>=18.1.0
   Using cached service_identity-18.1.0-py2.py3-none-any.whl (11 kB)
 Collecting incremental>=16.10.1
   Using cached incremental-17.5.0-py2.py3-none-any.whl (16 kB)
 Collecting attrs>=19.2.0
   Using cached attrs-20.3.0-py2.py3-none-any.whl (49 kB)
 Collecting PyHamcrest!=1.10.0,>=1.9.0
   Using cached PyHamcrest-2.0.2-py3-none-any.whl (52 kB)
 Collecting Automat>=0.3.0
   Using cached Automat-20.2.0-py2.py3-none-any.whl (31 kB)
 Collecting hyperlink>=17.1.1
   Using cached hyperlink-20.0.1-py2.py3-none-any.whl (48 kB)
 Collecting idna!=2.3,>=0.6
   Using cached idna-2.10-py2.py3-none-any.whl (58 kB)
 Collecting pyOpenSSL
   Using cached pyOpenSSL-20.0.0-py2.py3-none-any.whl (54 kB)
 Collecting cryptography
   Using cached cryptography-3.2.1-cp35-abi3-macosx_10_10_x86_64.whl (1.8
 MB)
 Collecting zope.interface
   Using cached zope.interface-5.2.0-cp39-cp39-macosx_10_9_x86_64.whl (194
 kB)
 Requirement already satisfied: setuptools in ./env/lib/python3.9/site-
 packages (from zope.interface->mypy-zope@ git+https://github.com/jaraco
 /mypy-zope at bugfix/21-InterfaceClass-subclass) (49.2.1)
 Collecting six
   Using cached six-1.15.0-py2.py3-none-any.whl (10 kB)
 Collecting pyasn1-modules
   Using cached pyasn1_modules-0.2.8-py2.py3-none-any.whl (155 kB)
 Collecting pyasn1
   Using cached pyasn1-0.4.8-py2.py3-none-any.whl (77 kB)
 Collecting cffi!=1.11.3,>=1.8
   Using cached cffi-1.14.4-cp39-cp39-macosx_10_9_x86_64.whl (177 kB)
 Collecting pycparser
   Using cached pycparser-2.20-py2.py3-none-any.whl (112 kB)
 Collecting zope.schema
   Using cached zope.schema-6.0.0-py2.py3-none-any.whl (85 kB)
 Requirement already satisfied: setuptools in ./env/lib/python3.9/site-
 packages (from zope.interface->mypy-zope@ git+https://github.com/jaraco
 /mypy-zope at bugfix/21-InterfaceClass-subclass) (49.2.1)
 Collecting zope.event
   Using cached zope.event-4.5.0-py2.py3-none-any.whl (6.8 kB)
 Requirement already satisfied: setuptools in ./env/lib/python3.9/site-
 packages (from zope.interface->mypy-zope@ git+https://github.com/jaraco
 /mypy-zope at bugfix/21-InterfaceClass-subclass) (49.2.1)
 Using legacy 'setup.py install' for mypy-zope, since package 'wheel' is
 not installed.
 Using legacy 'setup.py install' for foolscap, since package 'wheel' is not
 installed.
 Installing collected packages: pycparser, six, pyasn1, idna, cffi, attrs,
 zope.interface, PyHamcrest, pyasn1-modules, incremental, hyperlink,
 cryptography, constantly, Automat, zope.event, typing-extensions, typed-
 ast, twisted, service-identity, pyOpenSSL, mypy-extensions, zope.schema,
 mypy, mypy-zope, foolscap
     Running setup.py install for mypy-zope ... done
     Running setup.py install for foolscap ... done
 Successfully installed Automat-20.2.0 PyHamcrest-2.0.2 attrs-20.3.0
 cffi-1.14.4 constantly-15.1.0 cryptography-3.2.1
 foolscap-20.4.0+5.gd70d8ec hyperlink-20.0.1 idna-2.10 incremental-17.5.0
 mypy-0.790 mypy-extensions-0.4.3 mypy-zope-0.2.9.dev0 pyOpenSSL-20.0.0
 pyasn1-0.4.8 pyasn1-modules-0.2.8 pycparser-2.20 service-identity-18.1.0
 six-1.15.0 twisted-20.3.0 typed-ast-1.4.1 typing-extensions-3.7.4.3
 zope.event-4.5.0 zope.interface-5.2.0 zope.schema-6.0.0
 WARNING: You are using pip version 20.2.3; however, version 20.2.4 is
 available.
 You should consider upgrading via the '/Users/jaraco/code/public/tahoe-
 lafs/test/env/bin/python -m pip install --upgrade pip' command.
 test $ env/bin/mypy remote.py
 remote.py:18: error: 'BucketWriter' is missing following 'RIBucketWriter'
 interface members: write.
 Found 1 error in 1 file (checked 1 source file)
 }}}

 Right, so I'm reminded of
 [[https://github.com/python/mypy/issues/9678|python/mypy#9678]]. I just
 need to stay away from pip-run for now. At least, I've replicated the
 issue now in an isolated environment. I'll take that to the foolscap
 project.

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3399#comment:21>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage


More information about the tahoe-lafs-trac-stream mailing list