[tahoe-lafs-trac-stream] [Tahoe-LAFS] #2735: remove "bin/tahoe" and fancy "@" runner support

Tahoe-LAFS trac at tahoe-lafs.org
Wed Jan 13 19:43:03 UTC 2021


#2735: remove "bin/tahoe" and fancy "@" runner support
--------------------------------+-----------------------
     Reporter:  warner          |      Owner:
         Type:  task            |     Status:  new
     Priority:  normal          |  Milestone:  undecided
    Component:  code-nodeadmin  |    Version:  1.10.2
   Resolution:                  |   Keywords:
Launchpad Bug:                  |
--------------------------------+-----------------------

Comment (by exarkun):

 Some updates:
   * For ticket:3588 I added direct test coverage for two non-ASCII-related
 behaviors of a process that is using `allmydata/windows/fixups.py`:
 receiving such values in argv and writing such values to stdout and
 stderr.  This very directly tests the behavior that
 `BinTahoe.test_unicode_arguments_and_output` is also meant to test - but
 without getting `allmydata.scripts.runner` involved.
   * Because there is no longer a wrapper script for tahoe on Windows, for
 ticket:3581 I was able to remove all of the unicode "mangling" being done
 for Windows and adapted `BinTahoe.test_unicode_arguments_and_output` so
 that it still tests argv/output functionality conferred upon
 `allmydata.scripts.runner` by `allmydata.windows.fixups`.  I think
 `BinTahoe.test_unicode_arguments_and_output` is now pretty fine to keep.
   * `RunNode` still exists but it seems to have been cleaned up a lot
 since this ticket was filed.  It still doesn't strike me as uniformly
 fantastic but neither does it seem like a substantial liability.

 So we may be zeroing in on being able to consider this ticket resolved.

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2735#comment:4>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage


More information about the tahoe-lafs-trac-stream mailing list