[tahoe-lafs-trac-stream] [Tahoe-LAFS] #3600: allmydata.test.common.*TestCase have broken skip/cleanup interaction

Tahoe-LAFS trac at tahoe-lafs.org
Tue Jan 26 21:22:46 UTC 2021


#3600: allmydata.test.common.*TestCase have broken skip/cleanup interaction
-------------------------+-----------------------
     Reporter:  exarkun  |      Owner:
         Type:  defect   |     Status:  new
     Priority:  normal   |  Milestone:  undecided
    Component:  unknown  |    Version:  n/a
   Resolution:           |   Keywords:
Launchpad Bug:           |
-------------------------+-----------------------

Comment (by exarkun):

 It seems like the solution may be to stop using cleanups for this cleanup.

 Instead, rely on the fact that `testtools.runtest.RunTest.run` is actually
 a synchronous interface (even in the case of AsyncTestCase).  This means
 we can just use try/finally to manage cleanups.

 As a bonus, this probably makes a lot of the code simpler.

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3600#comment:1>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage


More information about the tahoe-lafs-trac-stream mailing list