[tahoe-lafs-trac-stream] [Tahoe-LAFS] #4048: Fix the `cli_options.stdout` pattern
Tahoe-LAFS
trac at tahoe-lafs.org
Thu Jul 20 18:18:23 UTC 2023
#4048: Fix the `cli_options.stdout` pattern
---------------------+---------------------------
Reporter: exarkun | Owner:
Type: defect | Status: new
Priority: normal | Milestone: undecided
Component: unknown | Version: n/a
Keywords: | Launchpad Bug:
---------------------+---------------------------
In tor_provider and i2p_provider, https://github.com/tahoe-lafs/tahoe-
lafs/pull/1283 introduced a couple type ignore comments to suppress the
mypy error now present in those places due to new type annotations. The
error complains about `Options` having no `stdout` attribute. It's true
the type doesn't generally, but `runner.py` puts one there.
Instead of dynamically adding extra attributes to `Options`, the code
should either pass stdout (and stderr I think?) separately or introduce a
new type specifically for representing an options value and some more
stuff.
--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/4048>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage
More information about the tahoe-lafs-trac-stream
mailing list