[tahoe-lafs-trac-stream] [Tahoe-LAFS] #4004: Abstract over configuration manipulation done by `write_node_config` in `create_node.py`

[Tahoe-LAFS]

#4004: Abstract over configuration manipulation done by `write_node_config` in
`create_node.py`
---------------------+---------------------------
 Reporter:  exarkun  |          Owner:
     Type:  defect   |         Status:  new
 Priority:  normal   |      Milestone:  undecided
Component:  unknown  |        Version:  n/a
 Keywords:           |  Launchpad Bug:
---------------------+---------------------------
 The interface between the Tor/I2P providers and the rest of Tahoe is not
 very well defined.  Parts of it are explicit (for example,
 `IAddressFamily`) but a lot of it is implicit.  Also, the boundaries are
 unclear and a lot of responsibility for knowing how Tor/I2P works is
 smeared across other parts of the codebase.

 One place (but certainly not the only place) this manifests in particular
 is in `src/allmydata/scripts/create_node.py` where there is a _lot_ of
 knowledge about how Tor and I2P can be configured and what to do with that
 configuration.

 One very small step to improving this would be to provide an abstraction
 over "turn provider-specific configuration into general Tahoe-LAFS
 configuration" and then use it in the `write_node_config` function in this
 file.

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/4004>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage