[tahoe-lafs-trac-stream] [Tahoe-LAFS] #4027: If an Authorization header cannot be decoded using UTF-8 then a traceback is logged

[Tahoe-LAFS]

#4027: If an Authorization header cannot be decoded using UTF-8 then a traceback
is logged
---------------------+---------------------------------------
 Reporter:  exarkun  |          Owner:
     Type:  defect   |         Status:  new
 Priority:  normal   |      Milestone:  HTTP Storage Protocol
Component:  unknown  |        Version:  n/a
 Keywords:           |  Launchpad Bug:
---------------------+---------------------------------------
 {{{
 2023-05-05T19:39:51-0400 [twisted.web.server.Request#critical]
         Traceback (most recent call last):
           File "/home/exarkun/VirtualEnvs/tahoe-lafs/lib/python3.9/site-
 packages/twisted/web/server.py", line 292, in render
             body = resrc.render(self)
           File "/home/exarkun/VirtualEnvs/tahoe-lafs/lib/python3.9/site-
 packages/klein/_resource.py", line 215, in render
             d = maybeDeferred(_execute)
           File "/home/exarkun/VirtualEnvs/tahoe-lafs/lib/python3.9/site-
 packages/twisted/internet/defer.py", line 206, in maybeDeferred
             result = f(*args, **kwargs)
           File "/home/exarkun/VirtualEnvs/tahoe-lafs/lib/python3.9/site-
 packages/klein/_resource.py", line 205, in _execute
             d = maybeDeferred(
         --- <exception caught here> ---
           File "/home/exarkun/VirtualEnvs/tahoe-lafs/lib/python3.9/site-
 packages/twisted/internet/defer.py", line 206, in maybeDeferred
             result = f(*args, **kwargs)
           File "/home/exarkun/VirtualEnvs/tahoe-lafs/lib/python3.9/site-
 packages/klein/_app.py", line 230, in execute_endpoint
             return endpoint_f(
           File "/home/exarkun/VirtualEnvs/tahoe-lafs/lib/python3.9/site-
 packages/klein/_app.py", line 366, in _f
             return _call(instance, f, request, *a, **kw)
           File "/home/exarkun/VirtualEnvs/tahoe-lafs/lib/python3.9/site-
 packages/klein/_app.py", line 124, in _call
             result = __klein_f__(*args, **kwargs)
           File "/home/exarkun/Work/python/tahoe-
 lafs/src/allmydata/storage/http_server.py", line 120, in route
             request.requestHeaders.getRawHeaders("Authorization", [""])[
           File "/home/exarkun/VirtualEnvs/tahoe-lafs/lib/python3.9/site-
 packages/twisted/web/http_headers.py", line 271, in getRawHeaders
             return [v.decode("utf8") for v in values]
           File "/home/exarkun/VirtualEnvs/tahoe-lafs/lib/python3.9/site-
 packages/twisted/web/http_headers.py", line 271, in <listcomp>
             return [v.decode("utf8") for v in values]
         builtins.UnicodeDecodeError: 'utf-8' codec can't decode byte 0x81
 in position 17: invalid start byte
 }}}

 The request can presumably not receive any kind of success response but it
 should probably not trigger logging of a traceback either.

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/4027>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage