[tahoe-lafs-trac-stream] [Tahoe-LAFS] #4190: Broken tests: failUnlessRaises has been deprecated

[Tahoe-LAFS]

#4190: Broken tests: failUnlessRaises has been deprecated
-------------------------------+---------------------------
     Reporter:  hacklschorsch  |      Owner:  hacklschorsch
         Type:  defect         |     Status:  assigned
     Priority:  normal         |  Milestone:  undecided
    Component:  unknown        |    Version:  n/a
   Resolution:                 |   Keywords:
Launchpad Bug:                 |
-------------------------------+---------------------------

Comment (by hacklschorsch):

 For posterity / maybe this helps somebody sometime, I did:

 {{{
 python -m venv venv-3.13.9
 ./venv-3.13.9/bin/pip install --editable .[test]
 source venv-3.13.9/bin/activate

 # Find a test to check if our upcoming work does help anything.
 # I got it from the CircleCI build job test pane.
 # Running this should fail:
 python -m twisted.trial --rterrors allmydata.test.test_hashtree.Complete

 # Fix the problem
 cd src/allmydata
 rg -l failUnlessRaises | xargs sed -i 's/failUnlessRaises/assertRaises/'
 cd ../..

 # Run test again (this time it should succeed):
 python -m twisted.trial --rterrors allmydata.test.test_hashtree.Complete
 # Run all tests (to check we haven't broken something else...)
 python -m twisted.trial --rterrors allmydata

 }}}

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/4190#comment:4>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage