id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc	launchpad_bug
1346	desert-island test can pass incorrectly because packages are installed	davidsarah	davidsarah	"The desert-island test should be testing that the contents of the deps tarball are sufficient to build without downloading. It's actually testing that those contents plus any locally installed packages, are sufficient to build without downloading.

For example, a SUMO build of 1.8.2b1, with no dependencies installed, will download setuptools_trial from PyPI in order to build zfec. That [http://tahoe-lafs.org/buildbot/builders/clean/builds/2707/steps/test-desert-island/logs/stdio isn't caught by the desert-island builder] because it has zfec locally installed.

In fact that builder has pycryptopp, mock, pyasn1, pycrypto, Nevow, foolscap, Twisted, zope.interface, simplejson, zfec, pyOpenSSL, pyutil, argparse, and zbase32 installed, so it is not using any of those from the tarball.

I believe the test should warn if it has any lines that start with ""Using ""."	defect	closed	major	1.11.0	dev-infrastructure	1.8.1	fixed	buildbot desert-island sumo	zooko