#1592 closed enhancement (fixed)

Patch to add a favicon to the web UI

Reported by: marcusw Owned by: zooko
Priority: minor Milestone: 1.9.2
Component: code-frontend-web Version: 1.9.0
Keywords: aesthetics wui Cc: kpreid
Launchpad Bug:

Description

I came up with a small (almost trivial) git branch to add a favicon to the web UI. More information is available at the commit page on github.

Change History (21)

comment:1 Changed at 2011-11-19T23:12:52Z by davidsarah

I reviewed the XHTML changes on the git branch and they look good. I confirmed that those are all the XHTML files that need to be changed. I also like the favicon (if we're staying with Kevin Reid's icon more generally).

CC BY 3.0 Unported is not compatible with GPL, primarily because of the attribution requirement. (I hate acting the part of license compatibility enforcer, but care about getting updates to Tahoe-LAFS into distributions like Debian that are strict about that.) This probably means that Kevin Reid's icon needs to be relicensed, so that the derived favicon can be.

comment:2 Changed at 2011-11-19T23:13:26Z by davidsarah

  • Keywords licensing added; review-needed removed
  • Milestone changed from undecided to 1.10.0
  • Owner set to kreid

comment:3 Changed at 2011-11-20T02:15:16Z by marcusw

I was afraid of the licensing issues and totally understand (hence the long-winded git comment). Bad things happen to projects with sloppy copyright. Have you contacted kreid about relicensing?

If he agrees, you've got the go-ahead from me to relicense my derivative (the 16x16 icon) under whatever conditions he chooses.

comment:4 Changed at 2011-11-20T06:29:19Z by zooko

  • Cc kpreid added

comment:5 Changed at 2011-11-20T06:30:43Z by zooko

  • Owner changed from kreid to kpreid

Dear Kevin: may we please have permission to use your Tahoe-LAFS logo contributions under the same licences as Tahoe-LAFS itself? Actually, would you mind granting the Tahoe-LAFS Software Foundation permission to use it however that entity sees fit, with little or no restriction? Thank you!

(The reason we're asking is to include a favicon derived from your logo in the Tahoe-LAFS distribution to include in the WUI.)

comment:6 Changed at 2011-11-27T14:54:49Z by kpreid

I hereby give permission for my Tahoe logo designs and SVG files (all material at http://switchb.org/kpreid/2009/tahoe/ ) to reused, modified, and distributed under the same license(s) as Tahoe-LAFS itself, including any future relicensing or other such change which the developer community has consensus upon.

comment:7 Changed at 2011-12-16T04:34:13Z by davidsarah

  • Owner changed from kpreid to marcusw

comment:8 Changed at 2011-12-16T16:56:44Z by marcusw

Any idea when/whether this will be landed?

comment:9 Changed at 2011-12-16T23:23:56Z by zooko

  • Keywords licensing removed

I removed the licensing keyword. Thanks, Kevin! I don't see either a review-needed keyword or a reviewed keyword so I can't tell instantly what state this ticket is in. Someone please push this ticket further along! https://tahoe-lafs.org/trac/tahoe-lafs/wiki/PatchReviewProcess

Last edited at 2011-12-16T23:24:06Z by zooko (previous) (diff)

comment:10 Changed at 2011-12-17T01:38:11Z by marcusw

  • Keywords review-needed added

comment:11 Changed at 2011-12-17T01:43:26Z by davidsarah

  • Keywords licensing added

marcusw: your changes are still under the license at https://github.com/marcuswanner/tahoe-lafs/commit/b3ee8882f0819cab0efdcf1b7620bc9c74b2ff2f . You need to relax that license, as kpreid did.

comment:12 Changed at 2011-12-17T01:50:28Z by marcusw

I hereby give permission for my Tahoe logo designs and SVG files previously referenced in this ticket and that git commit message to be reused, modified, and distributed under the same license(s) as Tahoe-LAFS itself, including any future relicensing or other such change which the developer community has consensus upon. This release is in addition to the one on the git branch message.

The same applies to the files linked to in https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1185#comment:16

comment:13 Changed at 2011-12-17T02:02:26Z by davidsarah

  • Keywords licensing removed
  • Owner changed from marcusw to davidsarah
  • Status changed from new to assigned

Thanks. Reviewing.

comment:14 Changed at 2011-12-17T02:05:20Z by davidsarah

  • Keywords reviewed added; review-needed removed

Oh, I already reviewed it in comment:1. OK, I'll land this now.

comment:15 Changed at 2011-12-17T04:35:23Z by david-sarah@…

  • Resolution set to fixed
  • Status changed from assigned to closed

In 054374400e28cb00:

Marcus Wanner's favicon patch. fixes #1592

comment:16 Changed at 2011-12-17T04:37:29Z by davidsarah

  • Keywords review-needed added; reviewed removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

I added some tests in 531f562fcfcb7b68. Review needed for those, and also for a cleanup patch 4618571389c62d2f.

comment:17 Changed at 2011-12-17T04:40:39Z by davidsarah

  • Owner davidsarah deleted
  • Status changed from reopened to new

comment:18 Changed at 2011-12-17T15:59:44Z by zooko

  • Owner set to zooko
  • Status changed from new to assigned

comment:19 Changed at 2011-12-17T16:31:09Z by zooko

  • Keywords review-needed removed
  • Resolution set to fixed
  • Status changed from assigned to closed

comment:20 Changed at 2012-03-29T23:30:02Z by davidsarah

  • Milestone changed from 1.10.0 to 1.9.2

comment:21 Changed at 2012-03-29T23:30:31Z by davidsarah

  • Keywords aesthetics wui added
Note: See TracTickets for help on using tickets.