Opened at 2014-08-19T17:31:49Z

Closed at 2014-09-09T12:32:46Z

Last modified at 2014-09-09T12:33:15Z

#2281 closed defect (fixed)

remove trialcoverage (the bwverbose-coverage reporter plugin​)

Reported by: daira Owned by: daira
Priority: normal Milestone: 1.10.1
Component: packaging Version: 1.10.0
Keywords: twisted trial coverage cleanup reviewed Cc:
Launchpad Bug:

Description

See also ​https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1698

Change History (8)

comment:1 Changed at 2014-08-19T17:34:17Z by daira

Part of the motivation for this is to remove the need for setup_requires in setup.py, which is helpful to fix [placeholder].

Version 0, edited at 2014-08-19T17:34:17Z by daira (next)

comment:2 Changed at 2014-09-02T17:02:52Z by warner

  • Owner set to warner

comment:3 Changed at 2014-09-02T17:07:08Z by daira

[deleted]

Last edited at 2014-09-03T11:32:33Z by daira (previous) (diff)

comment:4 Changed at 2014-09-02T18:18:53Z by warner

  • Status changed from new to assigned

I'll either land these, or kick them out to 1.12

comment:5 Changed at 2014-09-05T05:53:45Z by warner

If/when we remove src/allmydata/test/trial_coverage.py, we should also remove twisted/plugins/allmydata_trial.py (and the whole twisted/ directory).

We should also remove the setup.py clause that looks for "--reporter" in sys.argv and adds "trialcoverage" to setup_requires. I'm not convinced that this even works right now.

comment:6 Changed at 2014-09-09T00:32:20Z by warner

  • Keywords needs-review added
  • Owner changed from warner to daira
  • Status changed from assigned to new

​https://github.com/tahoe-lafs/tahoe-lafs/pull/107

comment:7 Changed at 2014-09-09T12:32:46Z by daira

  • Resolution set to fixed
  • Status changed from new to closed

Committed in [f0fc048d5335e150a8f1ae551cdd9d1654fc1ee9/trunk].

comment:8 Changed at 2014-09-09T12:33:15Z by daira

  • Keywords reviewed added; needs-review removed
Note: See TracTickets for help on using tickets.