id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc	launchpad_bug
2966	src/allmydata/test/no_network.py, _NoNetworkClient.stopService fails to return a result	exarkun	exarkun	"`_NoNetworkClient` is part of the test infrastructure to be able to test `Node` without doing lots of failure-prone (and, I guess, unnecessary) network operations.

It overrides startService and stopService to bypass the normal node startup and shutdown.  However, its stopService implementation fails to return the result of the upcall it makes:

{{{
    def stopService(self):
        service.MultiService.stopService(self)
}}}

`stopService` is defined as returning a Deferred which fires when the service has stopped.  By failing to return the result of the upcall, none of the child services of the service collection will have their shutdown Deferreds waited on.  This leads to premature test completion which leads to ""dirty reactor"" errors from trial.
"	defect	closed	normal	undecided	dev-infrastructure	1.12.1	fixed