Make all test_runner tests work on cygwin

[davidsarah]

source:src/allmydata/test/test_runner.py​ skips some tests due to this code:

if "cygwin" in sys.platform.lower():
    raise unittest.SkipTest("We don't know how to make this test work on cygwin: spawnProcess seems to hang forever. We don't know if 'bin/tahoe start' can be run on cygwin.")

[davidsarah]

I strongly suspect that this code:

if sys.platform == "win32":
    bintahoe += ".exe"

should also apply to cygwin (which, like native Windows, uses an .exe filetype for executables). That might not be the only problem.

[zooko]

We need a cygwin buildslave! We had one, but it was powered off when allmydata.com moved out of their office at 555 De Haro Street. I suspect that the machine is now in Brian's closet waiting patiently for a "Set Up Tahoe-LAFS Buildslave Machines" party.

[zooko]

Marking this as Milestone="eventually". This ticket will be revived come the day that someone contributes a cygwin buildslave.

[davidsarah]

Replying to davidsarah:

I strongly suspect that this code:

if sys.platform == "win32":
    bintahoe += ".exe"

should also apply to cygwin (which, like native Windows, uses an .exe filetype for executables).

This is incorrect; the cygwin bin/tahoe script has no extension. (It is a script with a Python shebang header, not a Windows executable.)

[davidsarah]

See also #1119 (make cygwin a supported platform).

[davidsarah]

This might have been fixed by [4964/trunk/#file6], which made the runner tests use subprocess.Popen instead of (indirectly) Twisted's reactor.spawn.

[davidsarah]

Replying to davidsarah:

This might have been fixed by [4964/trunk/#file6], which made the runner tests use subprocess.Popen instead of (indirectly) Twisted's reactor.spawnProcess.

Assigning to me to check whether that fixed it.

[exarkun]

There does not appear to be sufficient interest in cygwin to warrant keeping this open.