Context Navigation

the WUI controls for setting the type of an uploaded file are confusing

Reported by:	zooko	Owned by:	warner
Priority:	major	Milestone:	1.9.0
Component:	code-frontend-web	Version:	1.9.0a2
Keywords:	usability wui mutable upload welcome-page review-needed	Cc:
Launchpad Bug:

Description

I was uploading a file and I thought that it was of type SDMF because of the radio button that was next to "SDMF" and was selected. A more careful examination shows that it was actually an immutable because of the less noticeable checkbox next to "Create mutable file" that was unselected. (See attached screen capture.)

Let's replace this checkbox/radio button combo with instead a single radio button which is exactly one of "immutable", "SDMF", "MDMF (experimental)".

I propose to make this change in 1.9.

Attachments (6)

screencap.png (11.0 KB) - added by zooko at 2011-09-26T17:48:22Z.
labels-on-left.png (40.1 KB) - added by davidsarah at 2011-10-02T00:01:03Z.: Labels on left
labels-on-right.png (39.9 KB) - added by davidsarah at 2011-10-02T00:01:34Z.: Labels on right
labels-on-right-v2.png (40.0 KB) - added by davidsarah at 2011-10-02T00:17:10Z.: Labels on right with tweaked spacing (I prefer this one)
test-1547.darcs.patch (26.8 KB) - added by davidsarah at 2011-10-02T04:07:48Z.: Tests for ref #1547. Note that the tests on #1552 also need to pass in order for the fix to work.
fix-1547.darcs.patch (36.6 KB) - added by davidsarah at 2011-10-02T04:08:30Z.: Change the file upload forms on directory and welcome pages to use a 3-way radio button to select immutable, SDMF, or MDMF. Add '(experimental)' to the label for creating an MDMF directory. Also improve the spacing of form elements. refs #1547. Depends on #1552.

Download all attachments as: .zip

Change History (16)

Changed at 2011-09-26T17:48:22Z by zooko

Attachment screencap.png added

comment:1 Changed at 2011-09-26T17:48:40Z by zooko

Owner set to warner

comment:2 Changed at 2011-09-26T18:14:13Z by davidsarah

Keywords welcome-page added

I made exactly the same mistake the first time I used this control. +1 on changing it to a single radio button for 1.9.

I also think that:

there should be more of a space between each button+label and the next (otherwise it isn't clear that the text applies to the button on its left);
there's no need for "(experimental)" in the MDMF label. In any case, the create-directory and create-file controls should be consistent in whether they include "(experimental)".

comment:3 Changed at 2011-09-26T18:32:34Z by warner

As RM, I'm +1 for landing this in 1.9 . I don't have the time this week to make a patch, though.. can someone else do that? I can review and land it.

comment:4 follow-up: ↓ 5 Changed at 2011-09-28T17:39:38Z by kevan

If no one minds waiting until Saturday, I can make a patch for this.

comment:5 in reply to: ↑ 4 Changed at 2011-09-28T18:34:57Z by zooko

Replying to kevan:

If no one minds waiting until Saturday, I can make a patch for this.

Fine with me -- I don't intend to spend any of *my* time directly working on 1.9 except on Friday/Saturday/Sunday. But I'm not the Release Manager.

Changed at 2011-10-02T00:01:03Z by davidsarah

Attachment labels-on-left.png added

Labels on left

Changed at 2011-10-02T00:01:34Z by davidsarah

Attachment labels-on-right.png added

Labels on right

Changed at 2011-10-02T00:17:10Z by davidsarah

Attachment labels-on-right-v2.png added

Labels on right with tweaked spacing (I prefer this one)

Changed at 2011-10-02T04:07:48Z by davidsarah

Attachment test-1547.darcs.patch added

Tests for ref #1547. Note that the tests on #1552 also need to pass in order for the fix to work.

Changed at 2011-10-02T04:08:30Z by davidsarah

Attachment fix-1547.darcs.patch added

Change the file upload forms on directory and welcome pages to use a 3-way radio button to select immutable, SDMF, or MDMF. Add '(experimental)' to the label for creating an MDMF directory. Also improve the spacing of form elements. refs #1547. Depends on #1552.