#898 closed defect (fixed)

add support for NixOS to iputil

Reported by: zooko Owned by: nobody
Priority: major Milestone: 1.10.1
Component: code-network Version: 1.5.0
Keywords: nixos pyutil iputil transparency Cc:
Launchpad Bug:

Description (last modified by zooko)

Here is a test failure: http://allmydata.org/buildbot/builders/Ludo%20NixOS-amd64/builds/0/steps/test/logs/stdio

This is because src/allmydata/util/iputil.py tries to invoke /sbin/ifconfig but there isn't a file by that name on NixOS.

Ludo has patches this for the NixOS package of Tahoe-LAFS, like this: https://svn.nixos.org/repos/nix/nixpkgs/trunk/pkgs/tools/networking/p2p/tahoe-lafs/default.nix

He says to see the "patchPhase" part of that file.

Change History (7)

comment:1 Changed at 2010-05-01T19:12:16Z by zooko

  • Owner changed from ludo to nobody

I don't think ludo is currently planning to work on this ticket, so I'm unassigning it from him. I would personally love to get NixOS which already maintains a package of Tahoe-LAFS (https://svn.nixos.org/repos/nix/nixpkgs/trunk/pkgs/tools/networking/p2p/tahoe-lafs/ ), to be a Supported system. So I would be grateful if someone would look at this issue.

comment:2 Changed at 2012-03-14T21:10:02Z by davidsarah

The way we currently determine which command to run in iputil is unnecessarily unportable and high-maintenance. In practice all Unices support one of a small number of command syntaxes to get local IP addresses. We should just try all of them whenever the OS is not Windows.

comment:3 Changed at 2013-05-27T17:31:19Z by zooko

  • Description modified (diff)

See #1988

comment:4 Changed at 2013-05-27T17:36:17Z by zooko

  • Keywords iputil transparency added

comment:5 Changed at 2013-06-25T18:15:57Z by Daira Hopwood <david-sarah@…>

In a493ee0bb641175ecf918e28fce4d25df15994b6/trunk:

iputil.py: add tests for recent changes. refs #1381, #1988, #982, #1064, #1536, #1935, #898, #1707, #1918

Signed-off-by: Daira Hopwood <david-sarah@…>

comment:6 Changed at 2013-06-27T01:43:57Z by daira

  • Resolution set to fixed
  • Status changed from new to closed

iputil on trunk no longer distinguishes between Unix variants, which fixes this bug.

comment:7 Changed at 2013-06-27T01:44:42Z by daira

  • Milestone changed from undecided to 1.11.0
Note: See TracTickets for help on using tickets.