[tahoe-dev] [tahoe-lafs] #834: clarify error message when upload fails due to insufficient servers of happiness

[tahoe-lafs]

#834: clarify error message when upload fails due to insufficient servers of
happiness
--------------------------------+-------------------------------------------
 Reporter:  zooko               |           Owner:  kevan    
     Type:  defect              |          Status:  new      
 Priority:  major               |       Milestone:  undecided
Component:  code-peerselection  |         Version:  1.5.0    
 Keywords:                      |   Launchpad_bug:           
--------------------------------+-------------------------------------------

Comment(by kevan):

 Hm.

 I agree that that message is confusing. I like your error message, too,
 and I think that it would fix the immediate problem.

 Do you think that {{{NotEnoughSharesError}}} is informative enough, given
 the new behavior? I'm on the fence.

 It seemed a lot easier to say {{{NotEnoughSharesError}}} and have it be
 meaningful with the {{{shares_of_happiness}}} behavior. In that case,
 you'd only raise the error if you failed to place enough shares on the
 grid. Now, {{{NotEnoughSharesError}}} can be raised not only for that, but
 because {{{servers_of_happiness}}} isn't satisfied, which doesn't
 immediately spring to my mind when I read {{{NotEnoughSharesError}}}.
 Maybe we could make something like {{{UnhappyGridError}}} -- something
 that gets raised where we raise {{{NotEnoughSharesError}}} in the peer
 selection process and elsewhere, where appropriate, when our upload is
 unsuccessful because {{{servers_of_happiness}}} isn't satisfied. This
 avoids overloading the meaning of the exception in other cases where it is
 used -- i.e., when downloading.

-- 
Ticket URL: <http://allmydata.org/trac/tahoe/ticket/834#comment:1>
tahoe-lafs <http://allmydata.org>
secure decentralized file storage grid