[tahoe-lafs-trac-stream] [pycryptopp] #46: Add combined AES+XSalsa20 cipher module
pycryptopp
trac at tahoe-lafs.org
Sun Dec 4 02:44:14 UTC 2011
#46: Add combined AES+XSalsa20 cipher module
------------------------+---------------------------
Reporter: randombit | Owner: dragonxue
Type: enhancement | Status: new
Priority: major | Milestone:
Version: 0.5.19 | Resolution:
Keywords: xsalsa20 | Launchpad Bug:
------------------------+---------------------------
Comment (by davidsarah):
I see some issues with the interface in [attachment:ciphercombiner.py]
(which, to avoid confusion, is not the same as the interface of the
pseudocode in the Description):
* why is the {{{key}}} parameter in the constructor optional?
* what are the setter methods for? They're not documented, and code using
them would have to be relying on implementation details of this particular
combiner.
* I would prefer a {{{process}}} method that takes a position, i.e. bytes
from start of stream, as a parameter. (In contrast, it's not clear at all
how the argument to {{{setCombinerIV}}} relates to the position.)
--
Ticket URL: <http://tahoe-lafs.org/trac/pycryptopp/ticket/46#comment:5>
pycryptopp <https://tahoe-lafs.org/trac/pycryptopp>
More information about the tahoe-lafs-trac-stream
mailing list