[tahoe-lafs-trac-stream] [tahoe-lafs] #1186: downloader: avoid redundant Share.loop calls

[tahoe-lafs]

#1186: downloader: avoid redundant Share.loop calls
-------------------------------+-------------------------
     Reporter:  warner         |      Owner:
         Type:  enhancement    |     Status:  closed
     Priority:  major          |  Milestone:  1.9.0
    Component:  code-encoding  |    Version:  1.8β
   Resolution:  duplicate      |   Keywords:  performance
Launchpad Bug:                 |
-------------------------------+-------------------------
Changes (by warner):

 * status:  new => closed
 * resolution:   => duplicate
 * milestone:  soon => 1.9.0


Comment:

 Nope, {{{ShareFinder}}} does the DYHB queries, so it's only involved once
 at the beginning of the download. It looks like I really meant
 {{{Share._got_data}}}, which is called multiple times per fetched block:
 one for the block data itself, another couple times for hashes, made worse
 by the fact that we're doing independent (although pipelined) foolscap
 {{{remote_read()}}}s, since we don't have an immutable {{{readv}}} storage
 API.

 But it turns out that this is a dup: #1268 is the real ticket, and it was
 fixed in [5083].

-- 
Ticket URL: <http://tahoe-lafs.org/trac/tahoe-lafs/ticket/1186#comment:2>
tahoe-lafs <http://tahoe-lafs.org>
secure decentralized storage